Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in / Register
GHC
GHC
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 4,321
    • Issues 4,321
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
    • Iterations
  • Merge Requests 362
    • Merge Requests 362
  • Requirements
    • Requirements
    • List
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Security & Compliance
    • Security & Compliance
    • Dependency List
    • License Compliance
  • Operations
    • Operations
    • Incidents
    • Environments
  • Analytics
    • Analytics
    • CI / CD
    • Code Review
    • Insights
    • Issue
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Glasgow Haskell Compiler
  • GHCGHC
  • Issues
  • #17712

Closed
Open
Opened Jan 20, 2020 by Ömer Sinan Ağacan@osa1Maintainer

T1969 test definition overrides compiler residency collection params

test('T1969',
     [# expect_broken(12437),
      collect_compiler_residency(20),
      collect_compiler_stats('bytes allocated', 1),
      only_ways(['normal']),

      extra_hc_opts('-dcore-lint -static'),
          # Leave -dcore-lint on for this one test, so that we have something
          # that will catch a regression in -dcore-lint performance.
     ],
     compile,
     [''])

Here the line extra_hc_opts(...) overrides extra hc opts set by collect_compier_residency:

RESIDENCY_OPTS = '+RTS -A256k -i0 -h -RTS'

def collect_compiler_residency(tolerance_pct: float):
    return [
        collect_compiler_stats(['peak_megabytes_allocated', 'max_bytes_used'], tolerance_pct),
        extra_hc_opts(RESIDENCY_OPTS),
        # The nonmoving collector does not support -G1
        omit_ways([WayName('nonmoving_thr_ghc')])
    ]

As a result we don't pass -A256k -i0 -h when building this test, and max residency numbers are very unstable.

Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
None
Due date
None
Reference: ghc/ghc#17712