Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in / Register
GHC
GHC
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 4,390
    • Issues 4,390
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
    • Iterations
  • Merge Requests 373
    • Merge Requests 373
  • Requirements
    • Requirements
    • List
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Operations
    • Operations
    • Incidents
    • Environments
  • Analytics
    • Analytics
    • CI / CD
    • Code Review
    • Insights
    • Issue
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Glasgow Haskell Compiler
  • GHCGHC
  • Issues
  • #19219

Closed
Open
Opened Jan 14, 2021 by Sebastian Graf@sgraf812Developer

Testrunner: Allocation report should display change even if it is to be accepted

When I accept a Metric Increase or Metric Decrease, I no longer see the difference in allocations in the report, although I might still be interested in seeing it. For example if I added a subsequent commit that might have improved a decrease (-7% to -42%) or worsened an increase (+2% to +38%).

What I see instead is just an empty "Baseline value" column, the updated "New value" column, an empty "Change" column and a NEW indicator to the right, e.g.

           T12234(optasm) ghc/alloc    66201040.0    65881488.0  -0.5%    
           T12425(optasm) ghc/alloc                 111459288.0        NEW
           T12545(normal) ghc/alloc                1865187560.0        NEW
           T12707(normal) ghc/alloc  1065552962.0  1060568144.0  -0.5%    

I don't particularly care for the Baseline, but I do care for the Change in percent.

Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
None
Due date
None
Reference: ghc/ghc#19219