Skip to content

base typos

typos

abtracts, aggree, arugment, autconf, caviats, commpiling, containg, definitionin, ensursing, givign, happending, impermissable, implicily, improted, incliudes, incorrectlt, incrementaly, interation, lateron, lookkup, mechasnism, neeed, ocasionally, preceeding, Registery, Represetation, ressurrect, reveived, seakable, specialision, wastefull, wether, whathever, writting

fixes

abstracts, agree, argument, autoconf, caveats, compiling, containing, definition in, ensuring, giving, happening, impermissible, implicitly, imported, includes, incorrectly, incrementally, iteration, later on, lookup, mechanism, needed, occasionally, preceding, Registry, Representation, resurrect, received, seekable, specialisation, wasteful, whether, whatever, writing

affected files

base/GHC/IO/StdHandles.hs
base/GHC/StaticPtr.hs
base/GHC/IO/Windows/Paths.hs
base/GHC/Base.hs
base/GHC/Event/Windows/FFI.hsc
base/Data/Semigroup/Internal.hs
base/Data/Ord.hs
base/GHC/IO/Unsafe.hs
base/GHC/List.hs
base/GHC/IO/FD.hs
base/Data/Traversable.hs
base/GHC/TypeNats/Internal.hs
base/GHC/TypeLits/Internal.hs
base/GHC/Stats.hsc
base/GHC/Foreign.hs
base/GHC/Foreign.hs
base/tests/list001.hs
base/GHC/ResponseFile.hs
base/Data/Traversable.hs
base/tests/IO/T18832.hs
base/tests/IO/T18832.hs
base/GHC/ForeignPtr.hs
base/GHC/IO/Encoding/Failure.hs
base/GHC/Stack/CloneStack.hs
base/GHC/Weak.hs
base/GHC/Stack/CloneStack.hs
base/tests/IO/T4144.hs
base/GHC/Enum.hs
base/GHC/Event/Windows.hsc
base/GHC/Ptr.hs
base/Text/Printf.hs

changelog typo

$ grep -n superceded ghc/libraries/base/changelog.md
472:    This functionality is superceded by the interfaces provided by
$ 

won't fix wrappered

$ perl -ne 'print if $. == 1711 .. 1720' ghc/libraries/base/GHC/Base.hs
{- Note [INLINE division wrappers]
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
The Int division functions such as 'quotRemInt' and 'divModInt' have
been manually worker/wrappered, presumably because they construct
*nested* products.
We intend to preserve the exact worker/wrapper split, hence we mark
the wrappers INLINE (#19267). That makes sure the optimiser doesn't
accidentally inline the worker into the wrapper, undoing the manual
split again.
-}
$ 

according to Developer discretion

change to unmarshal in CloneStack.hs

$ grep -nr unmarshal base
base/GHC/Stack/CloneStack.hs:163:unmarshalled with HSC. If there is no IPE for a return frame (which can easily
base/GHC/Stack/CloneStack.hs:233:    ipes <- mapM unmarshall stackEntries
base/GHC/Stack/CloneStack.hs:237:      unmarshall :: Ptr InfoProvEnt -> IO (Maybe StackEntry)
base/GHC/Stack/CloneStack.hs:238:      unmarshall ipe = if ipe == nullPtr then
base/GHC/Event/Windows.hsc:1119:    -- This call will unmarshal data from the C buffer but pointers inside of
$ 

and another typo

$ perl -ne 'print if $. == 87 .. 89' ghc/libraries/base/GHC/Stack/CloneStack.hs
2. `sendCloneStackMessage#` - A primop for cloning another thread's stack.
   Sends a RTS message (Messages.c) with a MVar to that thread. The cloned
   stack is reveived by taking it out of this MVar.
$ 
To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information