Stop exporting addrToByteArray, addrToByteArrayName and friends from Language.Haskell.TH.Syntax

addrToByteArray and addrToByteArrayName are two functions that are used in the Lift ByteArray instance. They are exported since all identifiers are currently exported from TH.Syntax.

I'm suggesting we remove these from the exports as they are just internals used to implement the instance.

I think exporting these was purely accidental.

added needs triage label

mentioned in merge request !12479 (merged)

We also export:

trueName,
falseName,
nothingName,
justName,
leftName,
rightName,
nonemptyName :: Name
liftString :: String -> Q Exp

Again I think these are purely there for the Lift instances. I'm not sure if they are intended to be used by end-users at all? Perhaps these shouldn't be exported?

I imagine these are just exported by accident.

removed needs triage label

added Ttask TemplateHaskell labels

added user-facing label

added newcomer label

I've just realised unlike the others, liftString is used by TH quote desugaring. It shouldn't change things too much but good to keep in mind

What's the resolution here? Wait until we are willing to force a breaking change on users of template-haskell? Perhaps check hackage search to see whether any client actually would be broken?

I get the sense that this would be OK to do right now. I'll check using hackage search that these aren't used by anyone.

I was thinking this would be a great "first MR" for someone at ZuriHac. It's quite simple but it would be a good way to test your dev env is working, etc.

Hackage search seems to be broken atm so I just downloaded Hackage locally using https://github.com/nh2/hackage-download, and ran ripgrep myself.

identifier	(actual) ecosystem usages
addrToByteArray	0
addrToByteArrayName	same as above
trueName	5 (singletons-th, HaRe, gitrev, hasbolt-extras, smartconstructor)
falseName	4 (singletons-th, HaRe, gitrev, hasbol-extras)
nothingName	2 (hdirect, smartconstructor)
justName	1 (smartconstructor)
leftName	1 (type-interpreter)
rightName	0
nonEmptyName	0
liftString	17! (react-flux, d-bus, update-nix-fetchgit, directory-layout, th-compat, ghc-exactprint, symantic-parser, ron-schema, generics-mrsop, pandoc-crossref, testCom, haskelm, candid, brok, clr-inline, composite-aeson, taskell)

So maybe we just stick to addrToByteArray and addrToByteArrayName

mentioned in issue #24783

changed title from Stop exporting addrToByteArray and addrToByteArrayName from Language.Haskell.TH.Syntax to Stop exporting addrToByteArray, addrToByteArrayName and friends from Language.Haskell.TH.Syntax

added Hacktoberfest label

mentioned in commit 2c95d6b9

mentioned in merge request !14226 (closed)

mentioned in commit 525612f5

mentioned in commit 01318925

mentioned in commit 67baf29c

mentioned in commit bbc2f110

mentioned in commit 5e7df774