Skip to content

Add an HLint config, address a few hints

Simon Jakobi requested to merge sjakobi/ghc:hlint-config into master

@sgraf812 brought up the idea to run HLint as part of our CI in !1010 (comment 202904).

For now I'm trying to address a few interesting hints (see the commit log for details).

report.zip contains an HLint HTML report with all hints enabled. The report was produced with the following command, skipping tests and submodules:

hlint --report `git ls-files | grep -v tests | grep -E "\.hs(|-boot|c)\$"`

Please take a few moments to verify that your commits fulfill the following:

  • are either individually buildable or squashed
  • have commit messages which describe what they do (referring to [Notes][notes] and tickets using #NNNN syntax when appropriate)
  • have added source comments describing your change. For larger changes you likely should add a [Note][notes] and cross-reference it from the relevant places.
  • add a testcase to the testsuite.
  • replace this message with a description motivating your change
Edited by Hécate Moonlight

Merge request reports