Skip to content

Draft: Generate HasField instances for record selectors with constraints (#22267)

Thank you for your contribution to GHC!

Please read the checklist below to make sure your contribution fulfills these expectations. Also please answer the following question in your MR description:

Where is the key part of this patch? That is, what should reviewers look at first?

compiler/GHC/Tc/Instance/Class.hs

Please take a few moments to address the following points:

  • if your MR touches base (or touches parts of ghc-internal used or re-exported by base) more substantially than just amending comments or documentation, you likely need to raise a CLC proposal before merging it.
  • if your MR may break existing programs (e.g. causes the compiler to reject programs), please describe the expected breakage and add the user-facing label. This will run ghc/head.hackage> to characterise the effect of your change on Hackage.
  • ensure that your commits are either individually buildable or squashed
  • ensure that your commit messages describe what they do (referring to tickets using #NNNN syntax when appropriate)
  • have added source comments describing your change. For larger changes you likely should add a Note and cross-reference it from the relevant places.
  • add a testcase to the testsuite.
  • updates the users guide if applicable
  • mentions new features in the release notes for the next release

If you have any questions don't hesitate to open your merge request and inquire in a comment. If your patch isn't quite done yet please do add prefix your MR title with WIP:.

Question from the author

  • Should I update notes and release note?

Other info

Done during ZuriHac 2025 with the help of @adamgundry thanks so much!

Note: my latop is not powerful enough to compile GHC, I'll try it at home.

Edited by Gautier DI FOLCO

Merge request reports

Loading