Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in / Register
GHC
GHC
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 4,392
    • Issues 4,392
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
    • Iterations
  • Merge Requests 376
    • Merge Requests 376
  • Requirements
    • Requirements
    • List
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Operations
    • Operations
    • Incidents
    • Environments
  • Analytics
    • Analytics
    • CI / CD
    • Code Review
    • Insights
    • Issue
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Glasgow Haskell Compiler
  • GHCGHC
  • Merge Requests
  • !1598

Closed
Opened Aug 18, 2019 by Alexey Kuleshevich@lehinsReporter3 of 4 tasks completed3/4 tasks
  • Report abuse
Report abuse

hpc:Make sure files are being read/written in UTF-8

  • Overview 48
  • Commits 1
  • Pipelines 16
  • Changes 8

Addition of readFileUtf8 and writeFileUtf8 and make hpc use them. It would be better to move those functions into hpc library, this way readTix could use it as well. But in all honesty, I think it would be best to have them available in base, but that is a long shot. In any case, I adjusted the imports a bit, so if functions with the same names will get added to Trace.Hpc.Utils, they will not mess anything up here.

Fixes #17073 (closed).

Please take a few moments to verify that your commits fulfill the following:

  • are either individually buildable or squashed
  • have commit messages which describe what they do (referring to Notes and tickets using #NNNN syntax when appropriate)
  • have added source comments describing your change. For larger changes you likely should add a Note and cross-reference it from the relevant places.
  • add a testcase to the testsuite.

If you have any questions don't hesitate to open your merge request and inquire in a comment. If your patch isn't quite done yet please do add prefix your MR title with WIP:.

Edited Nov 07, 2019 by Ben Gamari
Assignee
Assign to
Reviewer
Request review from
8.10.1
Milestone
8.10.1 (Past due)
Assign milestone
Time tracking
Reference: ghc/ghc!1598
Source branch: wip/T17073