Skip to content

hpc:Make sure files are being read/written in UTF-8

Alexey Kuleshevich requested to merge lehins/ghc:wip/T17073 into master

Addition of readFileUtf8 and writeFileUtf8 and make hpc use them. It would be better to move those functions into hpc library, this way readTix could use it as well. But in all honesty, I think it would be best to have them available in base, but that is a long shot. In any case, I adjusted the imports a bit, so if functions with the same names will get added to Trace.Hpc.Utils, they will not mess anything up here.

Fixes #17073 (closed).

Please take a few moments to verify that your commits fulfill the following:

  • are either individually buildable or squashed
  • have commit messages which describe what they do (referring to Notes and tickets using #NNNN syntax when appropriate)
  • have added source comments describing your change. For larger changes you likely should add a Note and cross-reference it from the relevant places.
  • add a testcase to the testsuite.

If you have any questions don't hesitate to open your merge request and inquire in a comment. If your patch isn't quite done yet please do add prefix your MR title with WIP:.

Edited by Ben Gamari

Merge request reports