Skip to content

Do not throw away backpack instantiations for module lookup cache

John Ericson requested to merge Ericson2314/ghc:instantiation-robust-module-cache-key into master

Currently, there is only one home package so this probably doesn't matter. But if we support multiple home packages, they could differ only in arguments (same indef component being applied).

It looks like it used to be this way before 4e8a0607, but that commit doesn't seem to comment on this change in the particular. (It's main purpose is creating the InstalledUnitId and recategorizing the UnitId expressions accordingly.)

Trying this as a separate commit for testing purposes. I leave it to others to decide whether this is a good change on its own.

CC @mpickering @ezyang

  • are either individually buildable or squashed
  • have commit messages which describe what they do (referring to Notes and tickets using #NNNN syntax when appropriate)
  • have added source comments describing your change. For larger changes you likely should add a Note and cross-reference it from the relevant places.
  • add a testcase to the testsuite.
  • replace this message with a description motivating your change

If you have any questions don't hesitate to open your merge request and inquire in a comment. If your patch isn't quite done yet please do add prefix your MR title with WIP:.

Merge request reports