Skip to content

Handle TagToEnum in the same big case as the other primops

John Ericson requested to merge Ericson2314/ghc:tag-to-enum-panic into master

Before, it was a panic because it was handled above. But there must have been an error in my reasoning (another caller?) because #17442 (closed) reported the panic was hit.

But, rather than figuring out what happened, I can just make it impossible by construction. By adding just a bit more bureaucracy in the return types, I can handle TagToEnum in the same case as all the others, so the big case is is now total, and the panic is removed.

Fixes #17442 (closed)

Please take a few moments to verify that your commits fulfill the following:

  • are either individually buildable or squashed
  • have commit messages which describe what they do (referring to Notes and tickets using #NNNN syntax when appropriate)
  • have added source comments describing your change. For larger changes you likely should add a Note and cross-reference it from the relevant places.
  • add a testcase to the testsuite.
  • replace this message with a description motivating your change

If you have any questions don't hesitate to open your merge request and inquire in a comment. If your patch isn't quite done yet please do add prefix your MR title with WIP:.

Edited by John Ericson

Merge request reports