Skip to content

Don't reload environment files on every setSessionDynFlags

The documentation for interpretPackageEnv says that the contents of an environment file are to be treated as command-line flags. In light of this, it's not clear why we have a single call to it inside setSessionDynFlags, which itself is called in various places for various reasons. I think it would make more sense to call interpretPackageEnv from parseDynamicFlags. This seems to fix #18125 (closed) and #16318 (closed) without regressions in the test suite. I'd be curious to know what @hvr thinks about this, and if he has a better idea as to how to fix those tickets.

Edited by Artem Pelenitsyn

Merge request reports