Skip to content

Make `Int`'s `mod` and `rem` strict in their first arguments

Sebastian Graf requested to merge wip/mod-rem-strict into master

They used to be strict until 4d2ac2d4 (9 years ago).

It's obviously better to be strict for performance reasons. It also blocks #18067 (closed).

Fixes #18187 (closed).

NoFib results:

--------------------------------------------------------------------------------
        Program         Allocs    Instrs
--------------------------------------------------------------------------------
        integer          -1.1%     +0.4%
   wheel-sieve2         +21.2%    +20.7%
--------------------------------------------------------------------------------
            Min          -1.1%     -0.0%
            Max         +21.2%    +20.7%
 Geometric Mean          +0.2%     +0.2%

Everything else unchanged. See below for assessment of wheel-sieve2 regression.

Edited by Sebastian Graf

Merge request reports