Better loop detection in findTypeShape
Andreas pointed out, in !3466 (closed), that my fix for #18304 was not quite right. This patch fixes it properly, by having just one RecTcChecker rather than (implicitly) two nested ones, in findTypeShape.
Step 1. Fetch and check out the branch for this merge request
git fetch origin git checkout -b "wip/T18304" "origin/wip/T18304"
Step 2. Review the changes locally
Step 3. Merge the branch and fix any conflicts that come up
git fetch origin git checkout "master" git merge --no-ff "wip/T18304"
Step 4. Push the result of the merge to GitLab
git push origin "master"
Note that pushing to GitLab requires write access to this repository.
Tip: You can also checkout merge requests locally by following these guidelines.
Andreas pointed out, in !3466 (closed), that my fix for #18304 was not quite right. This patch fixes it properly, by having just one RecTcChecker rather than (implicitly) two nested ones, in findTypeShape.