Skip to content

Make bkpcabal01 test compatible with new ordering requirements.

Edward Z. Yang requested to merge ezyang/ghc:wip/T16378 into master

Previously, our test did something like this:

  1. Typecheck p
  2. Typecheck q (which made use of an instantiated p)
  3. Build instantiated p
  4. Build instantiated q

Cabal previously permitted this, under the reasoning that during typechecking there's no harm in using the instantiated p even if we haven't build it yet; we'll just instantiate it on the fly with p.

However, this is not true! If q makes use of a Template Haskell splice from p, we absolutely must have built the instantiated p before we typecheck q, since this typechecking will need to run some splices. Cabal now complains that you haven't done it correctly, which we indeed have not!

Reordering so that we do this:

  1. Typecheck p
  2. Build instantiated p
  3. Typecheck q (which made use of an instantiated p)
  4. Build instantiated q

Fixes the problem. If Cabal had managed the ordering itself, it would have gotten it right.

Signed-off-by: Edward Z. Yang ezyang@fb.com

Merge request reports