Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in / Register
  • GHC GHC
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 5,264
    • Issues 5,264
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
  • Merge requests 565
    • Merge requests 565
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Glasgow Haskell CompilerGlasgow Haskell Compiler
  • GHCGHC
  • Merge requests
  • !519

Reinstantiate assertions from Trac #11371

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Krzysztof Gogolewski requested to merge wip/T11371 into master Mar 08, 2019
  • Overview 1
  • Commits 2
  • Pipelines 2
  • Changes 6

The goal of Trac #11371 is to enforce an invariant, by converting calls to substTyUnchecked to substTy. Those functions do the same thing, but the second one also checks an invariant. This check was initially an assertion, but later was downgraded to a warning. Here, I'm restoring the assertion, and converting bad calls into substTyUnchecked. This way, we can guard against regressions and slowly work towards removing the calls to substTyUnchecked. I'm also adding a regression test to Trac #13951.

Edited Mar 08, 2019 by Krzysztof Gogolewski
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: wip/T11371