Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in / Register
  • GHC GHC
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 5,248
    • Issues 5,248
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
  • Merge requests 561
    • Merge requests 561
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Glasgow Haskell CompilerGlasgow Haskell Compiler
  • GHCGHC
  • Merge requests
  • !97

Refactor GHCi UI to fix #11606, #12091, #15721, #16096

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Ömer Sinan Ağacan requested to merge osa1/ghc:wip/T16096 into master Jan 09, 2019
  • Overview 11
  • Commits 1
  • Pipelines 6
  • Changes 16

Instead of parsing and executing a statement or declaration directly we now parse them first and then execute in a separate step. This gives us the flexibility to inspect the parsed declaration before execution. Using this we now inspect parsed declarations, and if it's a single declaration of form x = y we execute it as let x = y instead, fixing a ton of problems caused by poor declaration support in GHCi.

To avoid any users of the modules I left execStmt and runDecls unchanged and added execStmt' and runDecls' which work on parsed statements/declarations.

Edited Jan 11, 2019 by Ömer Sinan Ağacan
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: wip/T16096