... | @@ -12,10 +12,18 @@ When reviewing a merge request here are a few things to check for: |
... | @@ -12,10 +12,18 @@ When reviewing a merge request here are a few things to check for: |
|
|
|
|
|
* Are the commits logically structure? Are their commit messages descriptive?
|
|
* Are the commits logically structure? Are their commit messages descriptive?
|
|
* Are ticket numbers referenced as appropriate?
|
|
* Are ticket numbers referenced as appropriate?
|
|
* Changelog entry included?
|
|
* Is a GHC release notes entry included (e.g. `docs/users_guide/*-notes.rst`)?
|
|
* Release notes entry included?
|
|
* Have changelog entries been added to any changed packages (e.g. `libraries/*/changelog.md`)?
|
|
* Test case present?
|
|
* Has a test case been added?
|
|
* Milestone and ~"backport needed" label set as appropriate
|
|
* Milestone and ~"backport needed" label set as appropriate
|
|
|
|
* Does the patch add a significant new user-facing feature to GHC? If so perhaps a [GHC proposal](https://github.com/ghc-proposals/ghc-proposals) is in order.
|
|
|
|
* Does the patch change GHC's core libraries (e.g. `base`, `template-haskell`, `ghc-prim`)? If so:
|
|
|
|
* Has the [core libraries committee](https://wiki.haskell.org/Core_Libraries_Committee) consented
|
|
|
|
* Has the ~"user facing" label been applied?
|
|
|
|
* Has the [head.hackage job](https://gitlab.haskell.org/ghc/head.hackage/) been run to characterise the effect of the change on user code?
|
|
|
|
* Changelog and release notes entries are mandatory
|
|
|
|
* Have package versions been bumped as appropriate?
|
|
|
|
* Has an entry been added to the next release's migration guide?
|
|
|
|
|
|
|
|
|
|
## Backports
|
|
## Backports
|
... | | ... | |