Skip to content
  • sheaf's avatar
    db1ce858
    Do deep subsumption when computing valid hole fits · db1ce858
    sheaf authored and Marge Bot's avatar Marge Bot committed
    This commit makes a couple of improvements to the code that
    computes "valid hole fits":
    
      1. It uses deep subsumption for data constructors.
         This matches up the multiplicities, as per
         Note [Typechecking data constructors].
         This fixes #26338 (test: LinearHoleFits).
    
      2. It now suggests (non-unidirectional) pattern synonyms as valid
         hole fits. This fixes #26339 (test: PatSynHoleFit).
    
      3. It uses 'stableNameCmp', to make the hole fit output deterministic.
    
    -------------------------
    Metric Increase:
        hard_hole_fits
    -------------------------
    db1ce858
    Do deep subsumption when computing valid hole fits
    sheaf authored and Marge Bot's avatar Marge Bot committed
    This commit makes a couple of improvements to the code that
    computes "valid hole fits":
    
      1. It uses deep subsumption for data constructors.
         This matches up the multiplicities, as per
         Note [Typechecking data constructors].
         This fixes #26338 (test: LinearHoleFits).
    
      2. It now suggests (non-unidirectional) pattern synonyms as valid
         hole fits. This fixes #26339 (test: PatSynHoleFit).
    
      3. It uses 'stableNameCmp', to make the hole fit output deterministic.
    
    -------------------------
    Metric Increase:
        hard_hole_fits
    -------------------------
Loading