1. 11 Jan, 2019 1 commit
  2. 10 Jan, 2019 1 commit
  3. 09 Jan, 2019 1 commit
    • Matthew Pickering's avatar
      Hadrian: Add support for building stage3 · 6486c6e4
      Matthew Pickering authored
      This ticket enables the building of a `stage3` compiler by making the
      build logic more consistent and predictable in Hadrian.
      
      Two of the main changes are:
      
      1. In order to build anything at stageN we use the package database
      present at stageN. Fixing #16069
      2. `haddock` and `ghc-tags` are built
      as stage1 executables (with the stage1 compiler) rather than as
      stage2 compiler. Fixing
      [hadrian#661](https://github.com/snowleopard/hadrian/issues/661)
      
      In order to build a stage3 compiler, you have to set the new `finalStage` hadrian option to `Stage3`.
      6486c6e4
  4. 08 Jan, 2019 1 commit
    • Ryan Scott's avatar
      Be pickier about unsaturated synonyms in :kind · 6b70cf61
      Ryan Scott authored
      Summary:
      We currently permit any and all uses of unsaturated type
      synonyms and type families in GHCi's `:kind` command, which allows
      strange interactions like this one:
      
      ```
      > :set -XTypeFamilies -XPolyKinds
      > type family Id (a :: k)
      > type instance Id a = a
      > type Foo x = Maybe
      > :kind! Id Foo
      ```
      
      This is probably a stretch too far, so this patch moves to disallow
      unsaturated synonyms that aren't at the top level (we still want to
      allow `:kind Id`, for instance). We do this by augmenting `GhciCtxt`
      with an additional `Bool` field to indicate if we are at the
      outermost level of the type being passed to `:kind` or not. See
      `Note [Unsaturated type synonyms in GHCi]` in `TcValidity` for the
      full story.
      
      Test Plan: make test TEST=T16013
      
      Reviewers: goldfire, bgamari
      
      Reviewed By: goldfire
      
      Subscribers: simonpj, goldfire, rwbarton, carter
      
      GHC Trac Issues: #16013
      
      Differential Revision: https://phabricator.haskell.org/D5471
      6b70cf61
  5. 07 Jan, 2019 3 commits
    • Alec Theriault's avatar
      Check that libs found by GCC aren't folders · 6b5ec08a
      Alec Theriault authored
      Summary:
      We use 'gcc -B<base-location> --print-file-name mylib.a' as a way of
      checking if 'gcc' can discover 'mylib.a' at the given location. However,
      this can break down if there is a folder caller 'mylib.a' that 'gcc' can
      discover. We can guard against this by explicitly checking that the path
      returned by 'gcc' is a file.
      
      This may seem like a far-fetched scenario, but since
      3d17f1f1, we look for libraries without
      any prefix or suffix (ie. 'extra-libraries: softfloat', we look for just
      'softfloat' as well as 'softloat.a', 'softfloat.dll.a', etc.) which means
      that there might actusally be a folder of that name in one of the base
      locations.
      
      Reviewers: Phyx, bgamari, hvr, angerman
      
      Reviewed By: Phyx, angerman
      
      Subscribers: angerman, rwbarton, carter
      
      GHC Trac Issues: #16063
      
      Differential Revision: https://phabricator.haskell.org/D5462
      6b5ec08a
    • Ben Gamari's avatar
      fix-submodules: Rip out typing · 1c9dab22
      Ben Gamari authored
      Debian Jessie only runs Python 3.4, whereas typing was introduced in Python 3.5.
      1c9dab22
    • Ben Gamari's avatar
      gitlab-ci: Clone haddock from its upstream repository · c0448c18
      Ben Gamari authored
      This ensures that changes requiring haddock changes can be built under CI.
      c0448c18
  6. 06 Jan, 2019 10 commits
    • Zejun Wu's avatar
      Hadrian: merge sections in profiling _p.a to .p_o for ghci · 9ea8dcea
      Zejun Wu authored
      This is the hadrain version of {D5169}
      
      * We build squashed .o and .p_o for ghci when `dynamicGhcPrograms` is
      `False`
      * We no longer build them for rts as ghci never loads it
      
      we need https://github.com/haskell/cabal/pull/5592 for cabal to copy
      the built `.p_o` file.
      
      Test Plan:
      ```
      $ grep dynamicGhc hadrian/UserSettings.hs
        , dynamicGhcPrograms = return False
      $ touch ...
      $ hadrian/build.sh --flavour=user -j --digest-or
      $ find _build/stage1/libraries/ -name 'HS*-*.*o' | wc
           62      62    3664
      ```
      
      ```
      $ grep -C3 dynamicGhc hadrian/UserSettings.hs
      userFlavour :: Flavour
      userFlavour = performanceFlavour
        { name = "user"
        , dynamicGhcPrograms = return False
        }
      $ hadrian/build.sh -j --flavour=user test --verbose
      Unexpected results from:
      TEST="T3807 T9208 T9293 annth_make ghci057 haddock.Cabal haddock.base
      haddock.compiler"
      
      SUMMARY for test run started at Wed Dec  5 17:45:39 2018 PST
       0:03:16 spent to go through
          6708 total tests, which gave rise to
         26015 test cases, of which
         19290 were skipped
      
            29 had missing libraries
          6600 expected passes
            88 expected failures
      
             3 caused framework failures
             0 caused framework warnings
             1 unexpected passes
             7 unexpected failures
             0 unexpected stat failures
      $ find _build -name 'HSbase*.*o'
      _build/stage1/lib/x86_64-linux-ghc-8.7.20181204/base-4.12.0.0/HSbase-4.1
      2.0.0.o
      _build/stage1/lib/x86_64-linux-ghc-8.7.20181204/base-4.12.0.0/HSbase-4.1
      2.0.0.p_o
      _build/stage1/libraries/base/build/HSbase-4.12.0.0.o
      _build/stage1/libraries/base/build/HSbase-4.12.0.0.p_o
      ```
      
      Reviewers: bgamari, simonmar, snowleopard
      
      Reviewed By: snowleopard
      
      Subscribers: alpmestan, rwbarton, carter
      
      GHC Trac Issues: #15779
      
      Differential Revision: https://phabricator.haskell.org/D5270
      9ea8dcea
    • Ryan Scott's avatar
      bbd58fb5
    • Zejun Wu's avatar
      Fix bindist for ghci library · 3fb726d0
      Zejun Wu authored
      Summary:
      https://phabricator.haskell.org/D5169 built libghci for both vanilla way
      and profiling way. We need to include both in the bindist list so they
      will be installed.
      
      Test Plan:
      ```
      $ grep '^BuildFlavour' mk/build.mk
      BuildFlavour=perf
      $ make test_bindist
      $ grep HSghc-prim bindist-list.uniq
      ghc-8.7.20190101/libraries/ghc-prim/dist-install/build/HSghc-prim-0.5.3.o
      ghc-8.7.20190101/libraries/ghc-prim/dist-install/build/HSghc-prim-0.5.3.p_o
      ghc-8.7.20190101/libraries/ghc-prim/dist-install/build/libHSghc-prim-0.5.3.a
      ghc-8.7.20190101/libraries/ghc-prim/dist-install/build/libHSghc-prim-0.5.3-ghc8.7.20190101.so
      ghc-8.7.20190101/libraries/ghc-prim/dist-install/build/libHSghc-prim-0.5.3_p.a
      ```
      3fb726d0
    • Ben Gamari's avatar
      make: Silence some xelatex output · 3a509d29
      Ben Gamari authored
      Currently build logs from GitLab CI around around 7 megabytes each. Of this,
      around 2 megabytes is latex output. This is quite silly as essentially all of
      this output is unresolved references in the early latex iterations.
      Here we silence this output.
      
      However, to make sure that we don't silence errors we allow each xelatex
      invocation besides the last to fail.
      3a509d29
    • Adam Sandberg Eriksson's avatar
      Remove OPTIONS_HADDOCK hide in favour for not-home · 24b39ce5
      Adam Sandberg Eriksson authored
      GHC Trac Issues: #15447
      24b39ce5
    • Ben Gamari's avatar
      gitlab-ci: Try reenabling PDF documentation on Darwin · 66b88ddd
      Ben Gamari authored
      Carter says that the builder issues have now been sorted.
      66b88ddd
    • Sven Tennie's avatar
      Add entry for #16031 to base/changelog.md · 0ff42f3f
      Sven Tennie authored
      0ff42f3f
    • Sven Tennie's avatar
      Fix precedence handling for Data.Fixed's Show instance (#16031) · 01b60b0e
      Sven Tennie authored
      Use `showsPrec` instead of `show` to respect the precedence of the surrounding
      context.
      01b60b0e
    • chessai's avatar
      Add -Wmissing-deriving-strategies · c121e33f
      chessai authored
      Warn users when -XDerivingStrategies is enabled but not used, at each
      potential use site.
      
      add -Wmissing-deriving-strategies
      
      Reviewers: bgamari, RyanGlScott
      
      Subscribers: andrewthad, rwbarton, carter
      
      GHC Trac Issues: #15798
      
      Differential Revision: https://phabricator.haskell.org/D5451
      c121e33f
    • Zejun Wu's avatar
      Respect prompt in GhciSettings · 08b8ea2f
      Zejun Wu authored
      Summary:
      This was broken when PromptFunction was introduced that the settings are
      ignored and default values are always used.
      
      Test Plan: ./validate
      08b8ea2f
  7. 05 Jan, 2019 2 commits
  8. 04 Jan, 2019 2 commits
  9. 03 Jan, 2019 3 commits
  10. 02 Jan, 2019 2 commits
  11. 01 Jan, 2019 2 commits
  12. 30 Dec, 2018 2 commits
  13. 29 Dec, 2018 3 commits
  14. 28 Dec, 2018 1 commit
  15. 27 Dec, 2018 2 commits
  16. 26 Dec, 2018 2 commits
    • Sergei Trofimovich's avatar
      aclocal.m4: drop obsolete -fno-stack-protector · 29ecb520
      Sergei Trofimovich authored
      Summary:
      Initially -fno-stack-protector was added for openbsd specifically for ghc-6.5:
          changeset:f638fdfe (2006)
      and later it was extended to cover osx:
          changeset:c2cd83e7 (2009)
      
      None of the reports hint at exact breakage. I guess both happened
      in -fvia-C mode where GHC's Evil Mangler had a chance to mangle
      stack canaries generated by fstack-protector.
      
      ghc has no evil mangler anymore and the change is not needed
      at least for C codegen.
      
      validated the patch on OpenBSD-6.4. No new failures compared to
      clean master branch.
      Signed-off-by: default avatarSergei Trofimovich <slyfox@gentoo.org>
      
      Test Plan: validated on OpenBSD
      
      Reviewers: bgamari
      
      Subscribers: rwbarton, erikd, carter
      
      GHC Trac Issues: #16046
      
      Differential Revision: https://phabricator.haskell.org/D5465
      29ecb520
    • Ben Gamari's avatar
      gitlab-ci: Try only building Windows in the quick flavour · 942b5019
      Ben Gamari authored
      It seems no matter how many machines I throw at Windows it's constantly behind.
      Perhaps the quick build flavour will be fast enough to allow us to keep until
      while we sort out our toolchain issues (#16084).
      942b5019
  17. 25 Dec, 2018 2 commits