Skip to content

Rework HsValBindsLR

Once Trees that Grow has been applied to the hsSyn AST, rework HsValBindsLR to simplify it.

From a comment on https://phabricator.haskell.org/D4147

Nothing here gives any clue that this is intended for the output of the renamer. And typechecker I think.

Plus I wonder if we'd be better served by

data HsValBindsLR idL idR
 = ValBinds
      [(RecFlag, LHsBindsLR idL idR)]
     [LSig GhcRn]

Then the parser can generate a giant singleton Rec and the renamer can sort it out. Less fuss.

Trac metadata
Trac field Value
Version 8.2.1
Type Task
TypeOfFailure OtherFailure
Priority normal
Resolution Unresolved
Component Compiler
Test case
Differential revisions
BlockedBy
Related
Blocking
CC
Operating system
Architecture
To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information