Skip to content

build system incorrectly includes build.mk unconditionally

  1. /libraries/base/Makefile.local unconditionally includes $(TOP)/mk/build.mk when in fact it should do something more along the lines of the following:

ifeq "$(Validating)" "YES" include $(TOP)/mk/validate-settings.mk -include $(TOP)/mk/validate.mk else -include $(TOP)/mk/build.mk # (Optional) build-specific configuration # endif

This error causes validation to fail when build.mk contains -Werror, as there are things within libraries/base which have not yet been caused to be warning-clean.

Here is a subset of files that mention build.mk and may be worth investigating:

  1. /configure.ac
  2. /distrib/cross-port
  3. /distrib/hc-build
  4. /mk/boilerplate.mk
  5. /mk/config.mk
  6. /mk/config.mk.in
  7. /mk/install.mk
  8. /mk/build.mk
  9. /mk/build.mk.sample
  10. /bindisttest/Makefile
  11. /compiler/ghci/keepCAFsForGHCi.c
  12. /compiler/ilxGen/tests/Makefile
  13. /compiler/ndpFlatten/TODO
  14. /libraries/base/Makefile.local
  15. /libraries/Makefile.local
  16. /libraries/Makefile
  17. /WindowsInstaller/MakeInstaller.txt
  18. /Makefile
Trac metadata
Trac field Value
Version 6.7
Type Bug
TypeOfFailure OtherFailure
Priority normal
Resolution Unresolved
Component Build System
Test case
Differential revisions
BlockedBy
Related
Blocking
CC
Operating system Unknown
Architecture Unknown
To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information