Conflicting definition in hs-boot file

Foo.hs:

module Foo where

import Bar

data Foo a

Foo.hs-boot:

module Foo where

data Foo a

Bar.hs:

module Bar where
import {-# SOURCE #-} Foo

With GHC 7.8.2 I'm getting the error

Foo.hs-boot:3:1:
    Type constructor ‘Foo’ has conflicting definitions in the module
    and its hs-boot file
    Main module: type role Foo phantom
                 data Foo a
    Boot file:   data Foo a

Trac metadata

Trac field	Value
Version	7.8.2
Type	Bug
TypeOfFailure	OtherFailure
Priority	normal
Resolution	Unresolved
Component	Compiler
Test case
Differential revisions
BlockedBy
Related
Blocking
CC
Operating system
Architecture

changed weight to 5

added Tbug Trac import labels

If I add a role annotation to the hs-boot file, this works.

My guess is that since the hs-boot doesn't have the information about the data constructors, it cannot infer the phantom role of the parameter.

Still, I wish I didn't have to deal with this. But if this isn't possible, at least the error message should suggest adding the role annotation to the hs-boot file.

assigned to @rae

Replying to [ticket:9204#comment:83916 Feuerbach]:

If I add a role annotation to the hs-boot file, this works

Yes, that's the solution.

.

My guess is that since the hs-boot doesn't have the information about the data constructors, it cannot infer the phantom role of the parameter.

Yes. As documented here, in the last bullet point before 4.7.10, role inference in hs-boot files defaults to representational, the most common case.

Still, I wish I didn't have to deal with this. But if this isn't possible, at least the error message should suggest adding the role annotation to the hs-boot file.

Yes, absolutely. I will fix in due course, and clarify some of this in the manual as well.

Trac metadata

Trac field	Value
Component	Compiler → Documentation

added documentation label

Trac metadata

Trac field	Value
Differential revisions	- → D458

mentioned in commit 90a2bb6f

mentioned in commit ee0f34d5

mentioned in commit ec8781f0

closed

Trac metadata

Trac field	Value
Resolution	Unresolved → ResolvedFixed
Test case	→ roles/should_fail/T9204

In the following example the complete data declaration happens to be present in the hs-boot file:

Foo.hs:

module Foo where

import Bar

data P a = P

Foo.hs-boot:

module Foo where

data P a = P

Bar.hs:

module Bar where
import {-# SOURCE #-} Foo

Could you now do role inference in the hs-boot file as well, so that the example compiles? My use-case is that I generate hs-boot files by copying whole declarations. Thank you.

reopened

changed weight to 3

unassigned @rae

Yes, the suggestion in ticket:9204#comment:95987 is reasonable: Use phantom as the default role in hs-boot files when the definition is supplied. Even today, GHC does do role inference in hs-boot files -- it just uses a different default. But there is no reason to change the default if a definition is supplied.

Thanks for the suggestion.

However, because this is a user-facing change, it's not appropriate (in my opinion) to make the change for 7.10. And, it's just barely possible that this will break code. The following compiles today:

A.hs-boot:

module A where

data P a = P

A.hs:

module A where

type role P representational
data P a = P

Under the proposed change, this example would fail due to the missing role annotation in the hs-boot file. That said, I'm still in favor of the change, just documenting what would break.

Trac metadata

Trac field	Value
Priority	normal → low
Resolution	ResolvedFixed → Unresolved

assigned to @rae

OK let's change this for 7.12, and document the change. Richard, you took ownership, so maybe do this whenever it's convenient to you.

Simon

mentioned in commit 72a92726

closed

This is a user-facing change, so wait until 7.12.

Trac metadata

Trac field	Value
Resolution	Unresolved → ResolvedFixed
Test case	roles/should_fail/T9204 → roles/should_fail/T9204 roles/should_compile/T9204b

changed milestone to %8.0.1

Milestone renamed

added Plow label