Skip to content

Move GHCi into main library in prep for !1410

John Ericson requested to merge wip/ghci-iserv-prep into master

Perhaps helps with #14335 too.

So just for some background, this a continuation of a line of work !891 (closed) kicked off fixing this by cleanly separating GHCI vs external interpreter vs internal interpreter in CPP, and then I in !1390 (closed) simplified the CPP by always building the external interpreter. The next step, !1410, is always building GHCi so the only CPP left is whether to support the internal interpreter: just like external interpreter support, GHCi support in an of itself doesn't incur bootstrapping or dependency problems, so I don't think the maintenance burden of CPP is worth it.

Please take a few moments to verify that your commits fulfill the following:

  • are either individually buildable or squashed
  • have commit messages which describe what they do (referring to Notes and tickets using #NNNN syntax when appropriate)
  • have added source comments describing your change. For larger changes you likely should add a Note and cross-reference it from the relevant places.
  • add a testcase to the testsuite.
  • replace this message with a description motivating your change

If you have any questions don't hesitate to open your merge request and inquire in a comment. If your patch isn't quite done yet please do add prefix your MR title with WIP:.

Edited by John Ericson

Merge request reports