StgToCmm: Use CmmRegOff smart constructor

Previously we would generate expressions of the form
`CmmRegOff BaseReg 0`. This should do no harm (and really should be
handled by the NCG anyways) but it's better to just generate a plain
`CmmReg`.
23 jobs for !3681 with wip/use-CmmRegOff-smart-ctor in 403 minutes and 52 seconds (queued for 3 seconds)
detached
Status Job ID Name Coverage
  Lint
passed #391358
lint
ghc-linters

00:00:16

passed #391359
lint
lint-linters

00:00:16

passed #391362
lint
lint-submods

00:00:22

passed #391360
lint
lint-testsuite

00:00:16

passed #391361
lint
typecheck-testsuite

00:00:15

 
  Quick Build
passed #391363
x86_64-linux
hadrian-ghc-in-ghci

00:09:57

 
  Build
passed #391364
x86_64-linux
validate-x86_64-linux-deb9-hadrian

01:37:51

 
  Full Build
failed #391367
aarch64-linux allowed to fail
validate-aarch64-linux-deb9

02:58:58

failed #391368
armv7-linux allowed to fail
validate-armv7-linux-deb9

03:20:17

passed #391369
x86_64-linux
validate-i386-linux-deb9

01:21:44

failed #391376
new-x86_64-windows test allowed to fail
validate-i386-windows

00:02:29

passed #391366
x86_64-darwin
validate-x86_64-darwin

01:11:13

passed #391370
x86_64-linux
validate-x86_64-linux-deb9-debug

01:12:34

passed #391372
x86_64-linux
validate-x86_64-linux-deb9-dwarf

01:13:35

passed #391371
x86_64-linux
validate-x86_64-linux-deb9-integer-simple

01:32:35

passed #391365
x86_64-linux
validate-x86_64-linux-deb9-unreg-hadrian

02:25:26

passed #391373
x86_64-linux
validate-x86_64-linux-fedora27

01:43:05

failed #391375
new-x86_64-windows test allowed to fail
validate-x86_64-windows

03:02:19

failed #391374
new-x86_64-windows test allowed to fail
validate-x86_64-windows-hadrian

03:13:26

 
  Cleanup
passed #391377
x86_64-darwin
cleanup-darwin

00:00:18

 
  Packaging
passed #391378
x86_64-linux
doc-tarball

00:03:42

 
  Testing
manual #391379
x86_64-linux allowed to fail manual
hackage
failed #391380
x86_64-linux
perf-nofib

00:15:38

 
Name Stage Failure
failed
validate-x86_64-windows-hadrian Full Build
GO version:   go1.13.8
Built: 2020-06-19T21:12:23+0000
OS/Arch: windows/amd64
Uploading artifacts...
Runtime platform
arch=amd64 os=windows pid=6600 revision=6214287e version=13.1.0
junit.xml: found 1 matching files and directories

WARNING: Failed to load system CertPool: crypto/x509: system root pool is not available on Windows
Uploading artifacts as "junit" to coordinator... ok
id=391374 responseStatus=201 Created token=w-pBq7f4
ERROR: Job failed: exit status 1
failed
perf-nofib Testing
ERROR: Downloading artifacts from coordinator... error  error=read tcp 172.17.0.2:56148->208.113.201.33:443: read: connection reset by peer id=391372 responseStatus=200 OK token=sp7mLtyf
WARNING: Retrying... error=invalid argument
Downloading artifacts from coordinator... ok
id=391372 responseStatus=200 OK token=sp7mLtyf
FATAL: zip: not a valid zip file
Uploading artifacts for failed job
Uploading artifacts...
WARNING: nofib.log: no matching files
ERROR: No files to upload
ERROR: Job failed: exit code 1
failed
validate-aarch64-linux-deb9 Full Build
Uploading artifacts...
ghc-aarch64-linux-deb9.tar.xz: found 1 matching files and directories

junit.xml: found 1 matching files and directories

performance-metrics.tsv: found 1 matching files and directories

Uploading artifacts as "archive" to coordinator... ok
id=391367 responseStatus=201 Created token=Wz31YTf5
Uploading artifacts...
junit.xml: found 1 matching files and directories

Uploading artifacts as "junit" to coordinator... ok
id=391367 responseStatus=201 Created token=Wz31YTf5
ERROR: Job failed: exit code 1
failed
validate-i386-windows Full Build
Git branch:   13-1-stable
GO version: go1.13.8
Built: 2020-06-19T21:12:23+0000
OS/Arch: windows/amd64
Uploading artifacts...
Runtime platform
arch=amd64 os=windows pid=6124 revision=6214287e version=13.1.0
WARNING: junit.xml: no matching files
ERROR: No files to upload
ERROR: Job failed: exit status 1
failed
validate-armv7-linux-deb9 Full Build
Uploading artifacts...
ghc-armv7-linux-deb9.tar.xz: found 1 matching files

junit.xml: found 1 matching files

performance-metrics.tsv: found 1 matching files

Uploading artifacts to coordinator... ok
id=391368 responseStatus=201 Created token=5XWmGzrK
Uploading artifacts...
junit.xml: found 1 matching files

Uploading artifacts to coordinator... ok
id=391368 responseStatus=201 Created token=5XWmGzrK
ERROR: Job failed: exit code 1
failed
validate-x86_64-windows Full Build
GO version:   go1.13.8
Built: 2020-06-19T21:12:23+0000
OS/Arch: windows/amd64
Uploading artifacts...
Runtime platform
arch=amd64 os=windows pid=9016 revision=6214287e version=13.1.0
junit.xml: found 1 matching files and directories

WARNING: Failed to load system CertPool: crypto/x509: system root pool is not available on Windows
Uploading artifacts as "junit" to coordinator... ok
id=391375 responseStatus=201 Created token=8f3UYQhW
ERROR: Job failed: exit status 1