Minor refactoring in deriveConstants

Mainly we now generate this

    data PlatformConstants = PlatformConstants {
          pc_CONTROL_GROUP_CONST_291 :: Int,
          pc_STD_HDR_SIZE :: Int,
          pc_PROF_HDR_SIZE :: Int,
          pc_BLOCK_SIZE :: Int,
      }

instead of

    data PlatformConstants = PlatformConstants {
        pc_platformConstants :: ()
        , pc_CONTROL_GROUP_CONST_291 :: Int
        , pc_STD_HDR_SIZE :: Int
        , pc_PROF_HDR_SIZE :: Int
        , pc_BLOCK_SIZE :: Int
        ...
      }

The first field has no use and according to (removed) comments it was to
make code generator's work easier.. if anything this version is simpler
because it has less repetition (the commas in strings are gone).
23 jobs for master in 674 minutes and 47 seconds (queued for 3 seconds)
Status Job ID Name Coverage
  Lint
passed #151458
lint
lint-linters

00:00:18

passed #151461
lint
lint-submods-branch

00:00:30

passed #151459
lint
lint-testsuite

00:00:21

passed #151460
lint
typecheck-testsuite

00:00:19

 
  Build
passed #151463
x86_64-linux
hadrian-ghc-in-ghci

00:21:57

passed #151465
x86_64-linux
release-x86_64-linux-deb9-dwarf

02:01:46

passed #151980
x86_64-linux
validate-x86_64-linux-deb9-debug

03:25:49

passed #151981
x86_64-linux
validate-x86_64-linux-deb9-hadrian

03:51:51

failed #151464
x86_64-linux
validate-x86_64-linux-deb9-debug

03:44:32

failed #151462
x86_64-linux
validate-x86_64-linux-deb9-hadrian

03:12:44

 
  Full Build
failed #151467
aarch64-linux allowed to fail
validate-aarch64-linux-deb9

01:50:35

passed #151468
x86_64-linux
validate-i386-linux-deb9

01:46:27

passed #151466
x86_64-darwin
validate-x86_64-darwin

00:56:16

passed #151469
x86_64-linux
validate-x86_64-linux-deb9-integer-simple

01:46:48

passed #151470
x86_64-linux
validate-x86_64-linux-deb9-unreg

02:26:18

passed #151471
x86_64-linux
validate-x86_64-linux-fedora27

01:35:50

failed #151473
x86_64-windows allowed to fail
validate-x86_64-windows

00:02:27

failed #151472
x86_64-windows allowed to fail
validate-x86_64-windows-hadrian

00:01:39

 
  Cleanup
passed #151474
x86_64-darwin
cleanup-darwin

00:00:06

 
  Packaging
failed #151475
x86_64-linux allowed to fail
doc-tarball

00:00:34

 
  Testing
manual #151476
x86_64-linux allowed to fail manual
hackage
passed #151477
x86_64-linux
perf-nofib

00:28:34

 
  Deploy
failed #151478
x86_64-linux allowed to fail
pages

00:02:51

 
Name Stage Failure
failed
pages Deploy
$ git checkout .gitmodules
$ git fetch https://gitlab.haskell.org/ghc/ghc-performance-notes.git refs/notes/perf:refs/notes/perf || true
From https://gitlab.haskell.org/ghc/ghc-performance-notes
9e1881c003..2ff0c96321 refs/notes/perf -> refs/notes/perf
$ mkdir -p public/doc
$ tar -xf haddock.html.tar.xz -C public/doc
tar: haddock.html.tar.xz: Cannot open: No such file or directory
tar: Error is not recoverable: exiting now
ERROR: Job failed: exit code 1
failed
validate-aarch64-linux-deb9 Full Build
cp: error writing 'cabal-cache/world': No space left on device
Uploading artifacts...
WARNING: ghc-*.tar.xz: no matching files
WARNING: junit.xml: no matching files
ERROR: No files to upload
Uploading artifacts...
WARNING: junit.xml: no matching files
ERROR: No files to upload
ERROR: Job failed: exit code 1
failed
validate-x86_64-windows Full Build
Runtime platform                                    arch=amd64 os=windows pid=4992 revision=1f513601 version=11.10.1
WARNING: ghc-*.tar.xz: no matching files
WARNING: junit.xml: no matching files
ERROR: No files to upload
Uploading artifacts...
Runtime platform
arch=amd64 os=windows pid=1808 revision=1f513601 version=11.10.1
WARNING: junit.xml: no matching files
ERROR: No files to upload
ERROR: Job failed: exit status 9
failed
validate-x86_64-windows-hadrian Full Build
Runtime platform                                    arch=amd64 os=windows pid=1192 revision=1f513601 version=11.10.1
WARNING: ghc.tar.xz: no matching files
WARNING: junit.xml: no matching files
ERROR: No files to upload
Uploading artifacts...
Runtime platform
arch=amd64 os=windows pid=7172 revision=1f513601 version=11.10.1
WARNING: junit.xml: no matching files
ERROR: No files to upload
ERROR: Job failed: exit status 9
failed
doc-tarball Packaging
Synchronizing submodule url for 'utils/hsc2hs'
$ git submodule update --init --recursive
$ git checkout .gitmodules
$ git fetch https://gitlab.haskell.org/ghc/ghc-performance-notes.git refs/notes/perf:refs/notes/perf || true
From https://gitlab.haskell.org/ghc/ghc-performance-notes
ba4bcb675f..9e1881c003 refs/notes/perf -> refs/notes/perf
$ if [ ! -f "$LINUX_BINDIST" ]; then # collapsed multi-line command
Error: ghc-x86_64-mingw32.tar.xz does not exist. Did the 64-bit Windows job fail?
ERROR: Job failed: exit code 1