Fix issue with duplicate reexported definitions (T23616)
When a class method was reexported, it's default methods were also showing up in the generated html page.
The simplest and most non-invasive fix is to not look for the default method if we are just exporting the class method.. because the backends are just showing default methods when the whole class is exported.
In general it would be worthwhile to rewrite this bit of code I think as
the logic and what gets included is split over lookupDocs
and
availExportDecl
it would be clearer to combine the two. The result of
lookupDocs is always just passed to availExportDecl so it seems simpler
and more obvious to just write the function directly.
Merge request reports
Activity
mentioned in issue ghc#23616 (closed)
added 3 commits
-
bbc38201...1313adce - 2 commits from branch
ghc-head
- e8289bed - Fix issue with duplicate reexported definitions (T23616)
-
bbc38201...1313adce - 2 commits from branch
@mpickering I can't merge since I don't have write access to the target branch but I've approved it!
@sheaf could this please be merged and backported to GHC 9.8? Documentation looks unsatisfactory at the moment: https://ghc.gitlab.haskell.org/ghc/doc/libraries/base-4.19.0.0-inplace/Data-List.html#v:-36-dmmaximum
added 4 commits
-
e8289bed...5877bceb - 3 commits from branch
ghc-head
- c63347da - Fix issue with duplicate reexported definitions (T23616)
-
e8289bed...5877bceb - 3 commits from branch