Remove polymorphism from runProjectPreBuildPhase
Return a monomorphic TargetsMap from selectPlanSubset and put it in the final ProjectBuildContext. This causes slight duplication in CmdRun.hs, but not as bas as when we didn't return anything. In exchange, the final return type is much simpler. Note that CmdConfigure returns an empty TargetsMap, as configure doesn't accept targets.
Showing
- cabal-install/Distribution/Client/CmdBench.hs 2 additions, 2 deletionscabal-install/Distribution/Client/CmdBench.hs
- cabal-install/Distribution/Client/CmdBuild.hs 2 additions, 2 deletionscabal-install/Distribution/Client/CmdBuild.hs
- cabal-install/Distribution/Client/CmdConfigure.hs 3 additions, 2 deletionscabal-install/Distribution/Client/CmdConfigure.hs
- cabal-install/Distribution/Client/CmdHaddock.hs 2 additions, 2 deletionscabal-install/Distribution/Client/CmdHaddock.hs
- cabal-install/Distribution/Client/CmdRepl.hs 2 additions, 2 deletionscabal-install/Distribution/Client/CmdRepl.hs
- cabal-install/Distribution/Client/CmdRun.hs 24 additions, 9 deletionscabal-install/Distribution/Client/CmdRun.hs
- cabal-install/Distribution/Client/CmdTest.hs 2 additions, 2 deletionscabal-install/Distribution/Client/CmdTest.hs
- cabal-install/Distribution/Client/ProjectOrchestration.hs 12 additions, 12 deletionscabal-install/Distribution/Client/ProjectOrchestration.hs
Loading
Please register or sign in to comment