Allow whitespace in target selectors (564b4fe6) · Commits · Glasgow Haskell Compiler / Packages / Cabal · GitLab

Skip to content

GitLab

Explore

Sign in
Register

Primary navigation

Project

C

Cabal
- Activity
- Members
- Environments
- Terraform modules

Snippets Groups Projects

564b4fe6

Commit 564b4fe6 authored 10 months ago by Zoe Zuser Committed by Mikolaj 9 months ago

Downloads
- Patches
- Plain Diff

Allow whitespace in target selectors

Disallowing whitespace while parsing target selectors incorrectly
disallows file targets with whitespace in the paths, which can issues
when users pass absolute paths.

fixes #8875

parent a6b99b83

No related branches found

No related tags found

No related merge requests found

Changes 11

Hide whitespace changes

Inline Side-by-side

Showing

cabal-install/src/Distribution/Client/ScriptUtils.hs 2 additions, 2 deletions

cabal-install/src/Distribution/Client/ScriptUtils.hs
cabal-install/src/Distribution/Client/TargetSelector.hs 8 additions, 6 deletions

cabal-install/src/Distribution/Client/TargetSelector.hs
cabal-install/tests/IntegrationTests2.hs 5 additions, 3 deletions

cabal-install/tests/IntegrationTests2.hs
cabal-install/tests/IntegrationTests2/targets/simple/a p p/Main.hs 0 additions, 0 deletions

...tall/tests/IntegrationTests2/targets/simple/a p p/Main.hs
cabal-install/tests/IntegrationTests2/targets/simple/p.cabal 5 additions, 0 deletions

cabal-install/tests/IntegrationTests2/targets/simple/p.cabal
cabal-testsuite/PackageTests/NewBuild/T8875/T8875.cabal 9 additions, 0 deletions

cabal-testsuite/PackageTests/NewBuild/T8875/T8875.cabal
cabal-testsuite/PackageTests/NewBuild/T8875/a app/Main.hs 1 addition, 0 deletions

cabal-testsuite/PackageTests/NewBuild/T8875/a app/Main.hs
cabal-testsuite/PackageTests/NewBuild/T8875/cabal.out 8 additions, 0 deletions

cabal-testsuite/PackageTests/NewBuild/T8875/cabal.out
cabal-testsuite/PackageTests/NewBuild/T8875/cabal.project 1 addition, 0 deletions

cabal-testsuite/PackageTests/NewBuild/T8875/cabal.project
cabal-testsuite/PackageTests/NewBuild/T8875/cabal.test.hs 5 additions, 0 deletions

cabal-testsuite/PackageTests/NewBuild/T8875/cabal.test.hs
changelog.d/issue-8875 10 additions, 0 deletions

changelog.d/issue-8875

with 54 additions and 11 deletions

Loading

Mikolaj Konarski @Mikolaj
mentioned in commit haskell/cabal@a3c047d8
· 9 months ago

mentioned in commit haskell/cabal@a3c047d8

mentioned in commit haskell/cabal@a3c047d86d3fc9e915140e4c444d694d1e3aa0f1

Toggle commit list

0% Loading or .

You are about to add 0 people to the discussion. Proceed with caution.

Finish editing this message first!

Please register or sign in to comment