From aabd9aa4dc7887b393a653ef648825cc63f5518a Mon Sep 17 00:00:00 2001 From: Bardur Arantsson <bardur@scientician.net> Date: Tue, 8 Sep 2015 06:07:18 +0200 Subject: [PATCH] Change "XXX" markers to "TODO" --- Cabal/Distribution/PackageDescription/Check.hs | 2 +- cabal-install/Distribution/Client/Init.hs | 2 +- cabal-install/Distribution/Client/Init/Heuristics.hs | 2 +- cabal-install/tests/PackageTests/Freeze/Check.hs | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/Cabal/Distribution/PackageDescription/Check.hs b/Cabal/Distribution/PackageDescription/Check.hs index 5ff111479b..283c93c979 100644 --- a/Cabal/Distribution/PackageDescription/Check.hs +++ b/Cabal/Distribution/PackageDescription/Check.hs @@ -1146,7 +1146,7 @@ checkCabalVersion pkg = depsUsingWildcardSyntax = [ dep | dep@(Dependency _ vr) <- buildDepends pkg , usesWildcardSyntax vr ] - -- XXX: If the user writes build-depends: foo with (), this is + -- TODO: If the user writes build-depends: foo with (), this is -- indistinguishable from build-depends: foo, so there won't be an -- error even though there should be depsUsingThinningRenamingSyntax = diff --git a/cabal-install/Distribution/Client/Init.hs b/cabal-install/Distribution/Client/Init.hs index d0c6869a67..aa41e76e20 100644 --- a/cabal-install/Distribution/Client/Init.hs +++ b/cabal-install/Distribution/Client/Init.hs @@ -381,7 +381,7 @@ getModulesBuildToolsAndDeps :: InstalledPackageIndex -> InitFlags -> IO InitFlag getModulesBuildToolsAndDeps pkgIx flags = do dir <- maybe getCurrentDirectory return . flagToMaybe $ packageDir flags - -- XXX really should use guessed source roots. + -- TODO: really should use guessed source roots. sourceFiles <- scanForModules dir Just mods <- return (exposedModules flags) diff --git a/cabal-install/Distribution/Client/Init/Heuristics.hs b/cabal-install/Distribution/Client/Init/Heuristics.hs index 218080d36e..336875ae8b 100644 --- a/cabal-install/Distribution/Client/Init/Heuristics.hs +++ b/cabal-install/Distribution/Client/Init/Heuristics.hs @@ -175,7 +175,7 @@ findImportsAndExts projectRoot sf = do . lines $ s - -- XXX we should probably make a better attempt at parsing + -- TODO: We should probably make a better attempt at parsing -- comments above. Unfortunately we can't use a full-fledged -- Haskell parser since cabal's dependencies must be kept at a -- minimum. diff --git a/cabal-install/tests/PackageTests/Freeze/Check.hs b/cabal-install/tests/PackageTests/Freeze/Check.hs index 0353081c7f..8f2ca8c2df 100644 --- a/cabal-install/tests/PackageTests/Freeze/Check.hs +++ b/cabal-install/tests/PackageTests/Freeze/Check.hs @@ -42,7 +42,7 @@ tests paths = " ghc-prim ==" `isInfixOf` (intercalate " " $ lines $ c) , testCase "does not freeze packages which are not dependend upon" $ do - -- XXX Test this against a package installed in the sandbox but + -- TODO: Test this against a package installed in the sandbox but -- not depended upon. removeCabalConfig result <- cabal_freeze paths dir [] -- GitLab