Skip to content
GitLab
Projects
Groups
Snippets
Help
Loading...
Help
What's new
10
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Sign in / Register
Toggle navigation
Open sidebar
Glasgow Haskell Compiler
Packages
Cabal
Commits
cc5f025c
Commit
cc5f025c
authored
May 24, 2018
by
Alex Washburn
Committed by
recursion-ninja
May 24, 2018
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Adding TODOs regarding more robust build proceedures [skip ci]
parent
6719dd92
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
7 additions
and
0 deletions
+7
-0
Cabal/Distribution/Simple/GHC.hs
Cabal/Distribution/Simple/GHC.hs
+4
-0
Cabal/Distribution/Simple/PreProcess.hs
Cabal/Distribution/Simple/PreProcess.hs
+3
-0
No files found.
Cabal/Distribution/Simple/GHC.hs
View file @
cc5f025c
...
...
@@ -1352,6 +1352,10 @@ gbuild verbosity numJobs pkg_descr lbi bm clbi = do
opts
|
needProfiling
=
profCxxOpts
|
needDynamic
=
sharedCxxOpts
|
otherwise
=
vanillaCxxOpts
-- TODO: Placing all Haskell, C, & C++ objects in a single directory
-- Has the potential for file collisions. In general we would
-- consider this a user error. However, we should strive to
-- add a warning if this occurs.
odir
=
fromFlag
(
ghcOptObjDir
opts
)
createDirectoryIfMissingVerbose
verbosity
True
odir
needsRecomp
<-
checkNeedsRecompilation
filename
opts
...
...
Cabal/Distribution/Simple/PreProcess.hs
View file @
cc5f025c
...
...
@@ -538,6 +538,9 @@ ppC2hsExtras d = filter (\p -> takeExtensions p == ".chs.c") `fmap`
--TODO: perhaps use this with hsc2hs too
--TODO: remove cc-options from cpphs for cabal-version: >= 1.10
--TODO: Refactor and add seperate getCppOptionsForHs, getCppOptionsForCxx, & getCppOptionsForC
-- instead of combining all these cases in a single function. This blind combination can
-- potentially lead to compilation inconsistencies.
getCppOptions
::
BuildInfo
->
LocalBuildInfo
->
[
String
]
getCppOptions
bi
lbi
=
platformDefines
lbi
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment