Commit cc5f025c authored by Alex Washburn's avatar Alex Washburn Committed by recursion-ninja

Adding TODOs regarding more robust build proceedures [skip ci]

parent 6719dd92
......@@ -1352,6 +1352,10 @@ gbuild verbosity numJobs pkg_descr lbi bm clbi = do
opts | needProfiling = profCxxOpts
| needDynamic = sharedCxxOpts
| otherwise = vanillaCxxOpts
-- TODO: Placing all Haskell, C, & C++ objects in a single directory
-- Has the potential for file collisions. In general we would
-- consider this a user error. However, we should strive to
-- add a warning if this occurs.
odir = fromFlag (ghcOptObjDir opts)
createDirectoryIfMissingVerbose verbosity True odir
needsRecomp <- checkNeedsRecompilation filename opts
......@@ -538,6 +538,9 @@ ppC2hsExtras d = filter (\p -> takeExtensions p == ".chs.c") `fmap`
--TODO: perhaps use this with hsc2hs too
--TODO: remove cc-options from cpphs for cabal-version: >= 1.10
--TODO: Refactor and add seperate getCppOptionsForHs, getCppOptionsForCxx, & getCppOptionsForC
-- instead of combining all these cases in a single function. This blind combination can
-- potentially lead to compilation inconsistencies.
getCppOptions :: BuildInfo -> LocalBuildInfo -> [String]
getCppOptions bi lbi
= platformDefines lbi
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment