Commit d3f5f783 authored by Duncan Coutts's avatar Duncan Coutts Committed by Edward Z. Yang
Browse files

Clarify a TODO

The solverSettingFlagAssignment does not need to be eliminated, it's ok
to have both, but make a note that it does need validating at some
point.
parent bebbe9e6
......@@ -167,6 +167,8 @@ resolveSolverSettings ProjectConfig{
} =
SolverSettings {..}
where
--TODO: [required eventually] some of these settings need validation, e.g.
-- the flag assignments need checking.
solverSettingRemoteRepos = fromNubList projectConfigRemoteRepos
solverSettingLocalRepos = fromNubList projectConfigLocalRepos
solverSettingConstraints = projectConfigConstraints
......
......@@ -309,7 +309,7 @@ data SolverSettings
solverSettingLocalRepos :: [FilePath],
solverSettingConstraints :: [(UserConstraint, ConstraintSource)],
solverSettingPreferences :: [Dependency],
solverSettingFlagAssignment :: FlagAssignment, --TODO: [required eventually] eliminate this global one
solverSettingFlagAssignment :: FlagAssignment, -- ^ For all local packages
solverSettingFlagAssignments :: Map PackageName FlagAssignment,
solverSettingCabalVersion :: Maybe Version, --TODO: [required eventually] unused
solverSettingSolver :: PreSolver,
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment