Skip to content
GitLab
Menu
Projects
Groups
Snippets
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Sign in / Register
Toggle navigation
Menu
Open sidebar
Glasgow Haskell Compiler
Packages
Cabal
Commits
d80d2b04
Commit
d80d2b04
authored
Mar 31, 2016
by
Edward Z. Yang
Browse files
s/ToDo/TODO/
Signed-off-by:
Edward Z. Yang
<
ezyang@cs.stanford.edu
>
parent
4a60bb9f
Changes
3
Hide whitespace changes
Inline
Side-by-side
Cabal/Distribution/PackageDescription.hs
View file @
d80d2b04
...
...
@@ -349,7 +349,7 @@ instance Monoid ModuleRenaming where
instance
Semigroup
ModuleRenaming
where
ModuleRenaming
b
rns
<>
ModuleRenaming
b'
rns'
=
ModuleRenaming
(
b
||
b'
)
(
rns
++
rns'
)
-- T
oDo
: dedupe?
=
ModuleRenaming
(
b
||
b'
)
(
rns
++
rns'
)
-- T
ODO
: dedupe?
-- NB: parentheses are mandatory, because later we may extend this syntax
-- to allow "hiding (A, B)" or other modifier words.
...
...
Cabal/Distribution/Simple/Configure.hs
View file @
d80d2b04
...
...
@@ -448,11 +448,11 @@ configure (pkg_descr0', pbi) cfg = do
-- used in several ways:
--
-- * We'll use it to do a consistency check so we're not depending
-- on multiple versions of the same package (T
oDo
: someday relax
-- on multiple versions of the same package (T
ODO
: someday relax
-- this for private dependencies.) See right below.
--
-- * We feed it in when configuring the components to resolve
-- module reexports. (T
oDo
: axe this.)
-- module reexports. (T
ODO
: axe this.)
--
-- * We'll pass it on in the LocalBuildInfo, where preprocessors
-- and other things will incorrectly use it to determine what
...
...
@@ -481,9 +481,9 @@ configure (pkg_descr0', pbi) cfg = do
-- in the very original commit which introduced checking for
-- inconsistencies 5115bb2be4e13841ea07dc9166b9d9afa5f0d012,
-- and then moved out of PackageIndex and put here later.
-- T
oDo
: Try this code without it...
-- T
ODO
: Try this code without it...
--
-- T
oDo
: Move this into a helper function
-- T
ODO
: Move this into a helper function
let
pseudoTopPkg
::
InstalledPackageInfo
pseudoTopPkg
=
emptyInstalledPackageInfo
{
Installed
.
installedUnitId
=
...
...
@@ -508,7 +508,7 @@ configure (pkg_descr0', pbi) cfg = do
-- Compute installation directory templates, based on user
-- configuration.
--
-- T
oDo
: Move this into a helper function.
-- T
ODO
: Move this into a helper function.
defaultDirs
::
InstallDirTemplates
<-
defaultInstallDirs
(
compilerFlavor
comp
)
(
fromFlag
(
configUserInstall
cfg
))
...
...
@@ -518,7 +518,7 @@ configure (pkg_descr0', pbi) cfg = do
defaultDirs
(
configInstallDirs
cfg
)
-- Check languages and extensions
-- T
oDo
: Move this into a helper function.
-- T
ODO
: Move this into a helper function.
let
langlist
=
nub
$
catMaybes
$
map
defaultLanguage
(
allBuildInfo
pkg_descr
)
let
langs
=
unsupportedLanguages
comp
langlist
...
...
@@ -538,7 +538,7 @@ configure (pkg_descr0', pbi) cfg = do
-- Configure known/required programs & external build tools.
-- Exclude build-tool deps on "internal" exes in the same package
--
-- T
oDo
: Factor this into a helper package.
-- T
ODO
: Factor this into a helper package.
let
requiredBuildTools
=
[
buildTool
|
let
exeNames
=
map
exeName
(
executables
pkg_descr
)
...
...
cabal-install/Distribution/Client/BuildReports/Storage.hs
View file @
d80d2b04
...
...
@@ -103,7 +103,7 @@ storeLocal cinfo templates reports platform = sequence_
fromPathTemplate
(
substPathTemplate
env
template
)
where
env
=
initialPathTemplateEnv
(
BuildReport
.
package
report
)
-- T
oDo
: In principle, we can support $pkgkey, but only
-- T
ODO
: In principle, we can support $pkgkey, but only
-- if the configure step succeeds. So add a Maybe field
-- to the build report, and either use that or make up
-- a fake identifier if it's not available.
...
...
Write
Preview
Supports
Markdown
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment