Commit d80d2b04 authored by Edward Z. Yang's avatar Edward Z. Yang
Browse files

s/ToDo/TODO/



Signed-off-by: default avatarEdward Z. Yang <ezyang@cs.stanford.edu>
parent 4a60bb9f
...@@ -349,7 +349,7 @@ instance Monoid ModuleRenaming where ...@@ -349,7 +349,7 @@ instance Monoid ModuleRenaming where
instance Semigroup ModuleRenaming where instance Semigroup ModuleRenaming where
ModuleRenaming b rns <> ModuleRenaming b' rns' ModuleRenaming b rns <> ModuleRenaming b' rns'
= ModuleRenaming (b || b') (rns ++ rns') -- ToDo: dedupe? = ModuleRenaming (b || b') (rns ++ rns') -- TODO: dedupe?
-- NB: parentheses are mandatory, because later we may extend this syntax -- NB: parentheses are mandatory, because later we may extend this syntax
-- to allow "hiding (A, B)" or other modifier words. -- to allow "hiding (A, B)" or other modifier words.
......
...@@ -448,11 +448,11 @@ configure (pkg_descr0', pbi) cfg = do ...@@ -448,11 +448,11 @@ configure (pkg_descr0', pbi) cfg = do
-- used in several ways: -- used in several ways:
-- --
-- * We'll use it to do a consistency check so we're not depending -- * We'll use it to do a consistency check so we're not depending
-- on multiple versions of the same package (ToDo: someday relax -- on multiple versions of the same package (TODO: someday relax
-- this for private dependencies.) See right below. -- this for private dependencies.) See right below.
-- --
-- * We feed it in when configuring the components to resolve -- * We feed it in when configuring the components to resolve
-- module reexports. (ToDo: axe this.) -- module reexports. (TODO: axe this.)
-- --
-- * We'll pass it on in the LocalBuildInfo, where preprocessors -- * We'll pass it on in the LocalBuildInfo, where preprocessors
-- and other things will incorrectly use it to determine what -- and other things will incorrectly use it to determine what
...@@ -481,9 +481,9 @@ configure (pkg_descr0', pbi) cfg = do ...@@ -481,9 +481,9 @@ configure (pkg_descr0', pbi) cfg = do
-- in the very original commit which introduced checking for -- in the very original commit which introduced checking for
-- inconsistencies 5115bb2be4e13841ea07dc9166b9d9afa5f0d012, -- inconsistencies 5115bb2be4e13841ea07dc9166b9d9afa5f0d012,
-- and then moved out of PackageIndex and put here later. -- and then moved out of PackageIndex and put here later.
-- ToDo: Try this code without it... -- TODO: Try this code without it...
-- --
-- ToDo: Move this into a helper function -- TODO: Move this into a helper function
let pseudoTopPkg :: InstalledPackageInfo let pseudoTopPkg :: InstalledPackageInfo
pseudoTopPkg = emptyInstalledPackageInfo { pseudoTopPkg = emptyInstalledPackageInfo {
Installed.installedUnitId = Installed.installedUnitId =
...@@ -508,7 +508,7 @@ configure (pkg_descr0', pbi) cfg = do ...@@ -508,7 +508,7 @@ configure (pkg_descr0', pbi) cfg = do
-- Compute installation directory templates, based on user -- Compute installation directory templates, based on user
-- configuration. -- configuration.
-- --
-- ToDo: Move this into a helper function. -- TODO: Move this into a helper function.
defaultDirs :: InstallDirTemplates defaultDirs :: InstallDirTemplates
<- defaultInstallDirs (compilerFlavor comp) <- defaultInstallDirs (compilerFlavor comp)
(fromFlag (configUserInstall cfg)) (fromFlag (configUserInstall cfg))
...@@ -518,7 +518,7 @@ configure (pkg_descr0', pbi) cfg = do ...@@ -518,7 +518,7 @@ configure (pkg_descr0', pbi) cfg = do
defaultDirs (configInstallDirs cfg) defaultDirs (configInstallDirs cfg)
-- Check languages and extensions -- Check languages and extensions
-- ToDo: Move this into a helper function. -- TODO: Move this into a helper function.
let langlist = nub $ catMaybes $ map defaultLanguage let langlist = nub $ catMaybes $ map defaultLanguage
(allBuildInfo pkg_descr) (allBuildInfo pkg_descr)
let langs = unsupportedLanguages comp langlist let langs = unsupportedLanguages comp langlist
...@@ -538,7 +538,7 @@ configure (pkg_descr0', pbi) cfg = do ...@@ -538,7 +538,7 @@ configure (pkg_descr0', pbi) cfg = do
-- Configure known/required programs & external build tools. -- Configure known/required programs & external build tools.
-- Exclude build-tool deps on "internal" exes in the same package -- Exclude build-tool deps on "internal" exes in the same package
-- --
-- ToDo: Factor this into a helper package. -- TODO: Factor this into a helper package.
let requiredBuildTools = let requiredBuildTools =
[ buildTool [ buildTool
| let exeNames = map exeName (executables pkg_descr) | let exeNames = map exeName (executables pkg_descr)
......
...@@ -103,7 +103,7 @@ storeLocal cinfo templates reports platform = sequence_ ...@@ -103,7 +103,7 @@ storeLocal cinfo templates reports platform = sequence_
fromPathTemplate (substPathTemplate env template) fromPathTemplate (substPathTemplate env template)
where env = initialPathTemplateEnv where env = initialPathTemplateEnv
(BuildReport.package report) (BuildReport.package report)
-- ToDo: In principle, we can support $pkgkey, but only -- TODO: In principle, we can support $pkgkey, but only
-- if the configure step succeeds. So add a Maybe field -- if the configure step succeeds. So add a Maybe field
-- to the build report, and either use that or make up -- to the build report, and either use that or make up
-- a fake identifier if it's not available. -- a fake identifier if it's not available.
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment