diff --git a/Distribution/PackageDescription/QA.hs b/Distribution/PackageDescription/QA.hs index 0a17925bec6616975c0b5cd57d5f442c36074b06..8487e23758b696cab8b09181088db5786cfc7e3c 100644 --- a/Distribution/PackageDescription/QA.hs +++ b/Distribution/PackageDescription/QA.hs @@ -1,4 +1,3 @@ -{-# OPTIONS -cpp #-} ----------------------------------------------------------------------------- -- | -- Module : Distribution.PackageDescription.QA @@ -63,7 +62,9 @@ import Distribution.License (License(..)) -- TODO: and allmost ghc -X flags should be extensions -- TODO: Once we implement striping (ticket #88) we should also reject -- ghc-options: -optl-Wl,-s. --- TODO: check that either license or license-file is set +-- TODO: keep an eye on #190 and implement when/if it's closed. +-- warn for ghc-options: -fvia-C when ForeignFunctionInterface is set +-- http://hackage.haskell.org/trac/hackage/ticket/190 data QANotice = QAWarning { qaMessage :: String } @@ -124,10 +125,6 @@ ghcSpecific pkg_descr = do critical $ "Instead of using -ffi or -fffi, use extensions: " ++"ForeignFunctionInterface" - -- TODO: keep an eye on #190 and implement when/if it's closed. - -- warn for ghc-options: -fvia-C when ForeignFunctionInterface is set - -- http://hackage.haskell.org/trac/hackage/ticket/190 - where ghc_options = [ strs | bi <- allBuildInfo pkg_descr , (GHC, strs) <- options bi ]