GitLab

Currently Cabal just appends the pid to the package name-version
which makes it hard to see the actual package version number.
This patch just inserts a '-' between name-version and pid.

While here, simplify the argument list construction in
invocationAsShellScript a little bit.

We previously checked during preprocessing that there is some source
file for every module and produce a nice error message if not (rather
than having ghc --make fail later). We only looked for source files in
the source directories, ie not the target/output build dir, since the
build dir is where pre-processed files go, not original source files.
Igloo's change should allow builds where there is no original source file
at all, so long as there is some generated file in the build dir. In
particular this allows custom Setup.hs files to generate modules out of
thin air and for things to mostly work, even though the rest of the build
system is unaware about how the file got built.

Fixes hscolour'ing Config.hs in GHC

We were generating things like
    #define VERSION_ghc_prim"0.2.0.0"
rather than
    #define VERSION_ghc_prim "0.2.0.0"

I'm adding these type signatures to satisfy the "do not generalise
local let/where" rule that GHC is taking on.

The signatures are clearly correct, but I was surprised at the 
polymorphism needed.  For example

parseOptVersion :: ReadP r Version
parseOptVersion = parseQuoted ver <++ ver
  where ver :: ReadP r Version
        ver = parse <++ return noVersion
        noVersion = Version{ versionBranch=[], versionTags=[] }

Note that 'ver' really is called at two different types!  That 
in turn is because of the type of (<++)

  (<++) :: ReadP a a -> ReadP r a -> ReadP r a
  (+++) :: ReadP r a -> ReadP r a -> ReadP r a

Note the "a a" in the first arg, which is very unusual.
For example, compare the type of (+++).

Changing it to match the type of (+++) makes ReadP fail to compile,
though, so I assume it's right as it stands. But surely this deserves
a comment?!

Ticket #215 (Overhaul support for packages' tests).  Previously, the test-suite
stanza was allowed to contain a test-suite field, such as the executable stanza
parser allows.  This was removed because it is only required by legacy support
for executables and no legacy support is required for test suites.

Ticket #215 (Overhaul support for packages' tests).

Ticket #215 (Overhaul support for packages' tests).

Ticket #215 (Overhaul support for packages' tests).

The --help option output now prints only the first (if any)
long option. Because of this, --{enable,disable}-optimisation
(british spelling) is simply added to the list of options
without testing showOrParseArgs. --hyperlink-sources is now
also accepted for the haddock command.

The executable field is only for the legacy pre-Cabal-1.2 stanza syntax.

Ticket #215 (Overhaul support for packages' tests).  By parsing the test suite
stanza through an intermediate data structure, we can isolate errors due to
missing required fields in the parsing stage and avoid having error handlers
througout the code.

Ticket #215 (Overhaul support for packages' tests).

Ticket #215 (Overhaul support for packages' tests).

Ticket #215 (Overhaul support for packages' tests).  The previous output format
made it difficult to distinguish successful test suites from failed test
suites.

Ticket #215 (Overhaul support for packages' tests).  The use of the old
interface also makes it possible to log stdout and stderr without separating
the two.

Ticket #215 (Overhaul support for packages' tests).  Using a new format for the
test-suite stanza in the .cabal file, similar to the source-repository stanza.

Ticket #215 (Overhaul support for packages' tests).

Works around:
    libraries/Cabal/Distribution/Simple.hs:78:0:
        Warning: In the use of `runTests'
                 (imported from Distribution.Simple.UserHooks):
                 Deprecated: "Please use the new testing interface instead!"

Ticket #215 (Overhaul support for packages' tests). Deprecated 'runTests'
UserHook to maintain compatibility with old packages, but encourage authors to
update to the new interface.

Ticket #215 (Overhaul support for packages' tests). Log test output to a
uniquely named file in the system temporary directory. This avoids flooding the
terminal with long error messages.

Ticket #215 (Overhaul support for packages' tests).

Ticket #215 (Overhaul support for packages' tests).

Ticket #215 (Overhaul support for packages' tests). The 'test' command runs all
executable tests listed in the package description when the package is
configured with tests enabled. The exit codes and standard output/error are
collected and reported.

Ticket #215 (Overhaul support for packages' tests). Replaced generic error
message about unsupported test types with specific error messages for each
stage of the build/test process. This required changing the type of 'withTest'
to better match 'withExe' and 'withLib'.

Ticket #215 (Overhaul support for packages' tests). Check for 
duplicate testsuite name or modules during 'cabal check'.

Ticket #215 (Overhaul support for packages' tests). During 
package configuration, check for testsuites with the same name 
as other testsuites or executables.

Ticket #215 (Overhaul support for packages' tests). The
"--enable-tests" and "--disable-tests" command-line flags are
introduced, with "--disable-tests" being the default. If tests
are disabled, the testsuites are stripped from the
GenericPackageDescription during the configure stage, before
dependencies are resolved.

Ticket #215 (Overhaul support for packages' tests). Parse and
finalize a simple, dummy .cabal file containing a Test stanza.
Compare with the PackageDescription it which should result
from parsing.

Ticket #215 (Overhaul support for packages' test). During the
build stage, executable testsuites are handled analogously to
ordinary executables. This means their sources are
preprocessed and compiled. To actually compile, the build
stage actions are performed on a dummy Executable.