GitLab

[skip ci]

Refactor/cleanup of `String`/`ByteString` usage

Changelog entry:

> Change `rawSystemStdInOut` to use proper type to represent
> binary and textual data; new `Distribution.Utils.IOData` module;
> removed obsolete `startsWithBOM`, `fileHasBOM`, `fromUTF8`,
> and `toUTF8` functions; add new `toUTF8BS`/`toUTF8LBS`
> encoding functions. (#4666)

[skip ci]

This reduces the surface area of lib:Cabal by removing
entry points that Setup.hs scripts are very unlikely to
use.

Add 'store-dir' global flag for custom store location

This fixes the inconvenience occuring in `cabal.project` files of
separate `allow-*` statements overwriting each other. Currently,
without this patch,

    allow-newer: base
    allow-newer: directory

is *NOT* equivalent to

    allow-newer: base, directory

but rather to the last occurence of `allow-newer`, i.e.

    allow-newer: directory

This behaviour has been present since cabal 1.24

Augment `--allow-{newer,older}` syntax to support wildcards

This builds on top of a0d80350 (#4575)
and extends the syntax to support the token `all` or `*` to serve as
wild-card for the relaxation subject, i.e. the following non-exhaustive
list of forms is made possible (NB: the package name `all` is reserved
on Hackage):

    allow-newer: somepkg:*
    allow-newer: somepkg:all
    allow-newer: somepkg:^*
    allow-newer: somepkg:^all
    allow-newer: all:^all
    allow-newer: *:^all
    allow-newer: *:^*
    allow-newer: *:*
    allow-newer: all:all

Refer to the user's guide for details

This removes the redundancy between `RelaxDepsNone` and
`RelaxDepsSome []` by removing `RelaxDepsNone`.

This way we avoid the risk of subtle bugs that can occur if the same
semantic value can be expressed in a non-unique way.

A further step to normalise the type would be to turn `[RelaxedDep]`
into `Set RelaxedDep`, but there is no operation that would
significantly benefit from that yet.

[skip ci]

Use package root as data-file base path, not cwd

With cabal projects a package might depend on another inplace package in
the same project, so we need to add envoronment variables for each of
them when using new-run.

Using the current directory worked with single packages, but cabal
projects can use packages in different places.

Fixes #4639

Since we don't use those functions anymore, we can finally `DEPRECATE`
them.

This removes the remaining occurences of the weakly typed
`{to,from}UTF8` conversion.

This new type will be used to disentangle conflated uses of `String` and
clearly distinguish between binary and textual data.

This was introduced in 1821d803 but it
would imply that stdout was set to binary mode, which it isn't.

The API was assymetric, as there was `fromUTF8(L)BS` but not
the dual operations.

The plan is refactor all occurences of

 - `fromUTF8 :: String -> String`
 - `toUTF8`  :: String -> String`

until `fromUTF8`/`toUTF8` is unused, at which point
we can officially deprecate or remove it.

This is the proper type, as 'getFileContents' is supposed to return
contents read in binary file mode, and prior to this patch, `[Char]` was
abused to return binary data.

Refactor `getProgramInvocationOutput{,AndErrors}`

Bring stack.yaml up to date

This reduces code-duplication by sharing common code-paths.

Specifically, when `progInvokePathEnv` support was added, this wasn't
updated in `getProgramInvocationOutputAndErrors`.

...where it really belongs

Use default flags only for new-* path