GitLab

This tweaks the existing `CustomPlain` test to test the legacy
defaulting logic for the unconditionally `Custom` default.

Morever, a new `SimpleDefault` test has been added which tests
that `cabal-version:2.1` does indeed infer `build-type: Simple`
when there is no `custom-setup` stanza defined.

This implements the following defaulting rules:

 * For `cabal-version:2.0` and below, default to the `Custom`
   build-type unconditionally (legacy defaulting)

 * Otherwise, if a `custom-setup` stanza is defined, default to
   the `Custom` build-type; else default to `Simple` build-type.

This gets us better defaults for the two most popular use-cases, and
which can be statically inferred by only looking at the `.cabal` file.

This allows us to bring down the minimal (modern) trivial cabal
package definition down to a single file with 4 lines:

    cabal-version: 2.1
    name: mu
    version: 0
    library

NB: We don't need any `Setup.hs` file, as `cabal sdist` will magically
generate one on the fly.

This refactoring unifies the defaulting logic into a single place
paving the way for changing the defaulting logic.

[skip ci]

RFC: Common stanzas

- common stanzas can be include other common stanzas
- `import: name1, name2` to import multiple stanzas
- Parse common stanzas in the same pass with other sections.
- Common stanzas have to be defined before use.
- Also negative tests
- Terse documentation, let's improve it as questions are asked

- Edit gen-extra-source-files to include golden files
- Amend elif warning to mention cabal-version: 2.2
- In regression golden tests, include also warnings

Note: ATM the common stanzas are completely handled inside parser,
GenericPackageDescription doesn't know about them anymore.
That can be changed, but the the flattening of
GenericPackageDescription to PackageDescription may fail.
I don't want to do that refactor now.

[ci skip]

Should unbork the test suite.

fixed comment typo: 'is' to 'it' [ci skip]

Fix cases where "it's" was used as a possessive

[ci skip]

This represents an incremental improvement over the current state.
However, there's more work to be done in terms of restructuring/reordering
to present the information in an easier to digest as well as apply the new
facilities effectively. This future work will be tracked in #4944.

[skip ci]

Foreign lib names not parsed by readp

travis-ci: bootstrap on 8.2.2 as well

Skip the Haddock step on macOS.

I don't think it ever uncovered any bugs that the Linux bot
missed. This should speed up the build a little.

[ci skip]

[ci skip]

[ci skip]

[ci skip]

Initial feature add: create both Library and Executable on cabal init

Modify replacement properties of `encodeStringUtf8`/`decodeStringUtf8`

[ci skip]

Do not create folders when failing on no .project or .cabal file

This changes `decodeStringUtf8` to not replace U+FFFE and U+FFFF into
U+FFFD, while `encodeStringUtf8` now replaces surrogate pairs
(i.e. code-points U+D800 through U+DFFF which are invalid in UTF-8)
with U+FFFD.

Consequently, `decodeStringUtf8 . encodeStringUtf8` can now properly
round-trip all scalar code-points
(i.e. [U+0000..U+D7FF] ∪ [U+E000..U+10FFFF]).

This should finally address #4644

Restore a few integration test comments and new-build package arguments.

#4909 changed the cabal-version of the package under test, so this commit
adjusts the versions of the Cabal libraries in the test to be consistent with
the cabal-version.

Some comments were lost in the migration to the new integration test suite.