GitLab

[ci skip]

quasicomputational authored Jun 28, 2018 and Alexis Williams committed Jul 09, 2018

This has been a problem since #5372 began expanding globs in `cabal
check`. Now the logic of running a glob is separated from the parsing,
giving the caller the opportunity to handle parsing failures flexibly.

quasicomputational authored Jun 27, 2018 and Alexis Williams committed Jul 09, 2018

These globs make `haddock`, `sdist` and `install` die, so they
definitely ought to be warned about!

Because of the dying behaviour, I made the checks dist-inexcusable;
starting from a clean slate I would probably have only made them
suspicious, but this isn't terrible.

quasicomputational authored Jun 27, 2018 and Alexis Williams committed Jul 09, 2018

This also significantly improves the error when trying to refer to
missing directories, hopefully making it clear that it's coming from
Cabal. #5318 and snowleopard/hadrian#634 are two bugs which manifested
as Cabal trying to glob in a non-existent directory and both took some
debugging because of the obscurity of the error.