This project is mirrored from Pull mirroring updated .
  1. 06 Oct, 2016 36 commits
    • Edward Z. Yang's avatar
    • Edward Z. Yang's avatar
    • Edward Z. Yang's avatar
    • Edward Z. Yang's avatar
    • Edward Z. Yang's avatar
    • Edward Z. Yang's avatar
    • Edward Z. Yang's avatar
    • Edward Z. Yang's avatar
      A few cleanups and minor things · 26c67025
      Edward Z. Yang authored
      Add a clarification in packageTemplateEnv
      Improve the pre-processing message so we can see which unit is being
      built, not just the source component name.
      Debug output while building to print out the installed package info
      when we register information.
      Remove a done TODO about making sure the installed package registration
      files do not clash with each other, by including the full UnitId. This
      did not need any code changes here since dislaying the UnitId does the
      right thing.
    • Edward Z. Yang's avatar
      Fixup haddock backpack support · 9e59b862
      Edward Z. Yang authored
      1) Bugfix so that we get library source files from the correct
         directories (it was wrong previously; it only ever looked
         in the library directory)
      2) Search for hsig/lhsig files when looking for source files
    • Edward Z. Yang's avatar
      Teach GHC how to build indefinite libraries · fa79bdf0
      Edward Z. Yang authored
      These are libraries which don't have any code (uses 'whenHasCode'
      combinator).  In principle this could also be extended to support
      building anything with no code.
      Also update 'ghcOptThisUnitId' and 'ghcOptInstantiatedWith' to
      have correct values.
    • Edward Z. Yang's avatar
      Include signatures in SrcDist · 42af3567
      Edward Z. Yang authored
      Count signatures as modules that we have to find, and when searching for
      modules, look for .hsig or .lhsig files (in addition to the usual .hs
      .lhs files)
    • Edward Z. Yang's avatar
      Pre-build, make empty .hsig files for each requirement of the library · beff9e87
      Edward Z. Yang authored
      Part of the GHC/Cabal contract is that we always have a source file
      for everything GHC works on.
    • Edward Z. Yang's avatar
      Fix up component build directories to avoid clashes · 5173c9e4
      Edward Z. Yang authored
      Now that we can build a component multiple times with
      different instantiations, we need to make sure we give each
      instantiation a different build directory; done in 'buildDir'.
    • Edward Z. Yang's avatar
      Generate package registraion with instantiation info · ef7235c7
      Edward Z. Yang authored
      Correctly setup 'instantiatedWith' in 'InstalledPackageInfo'.
      Also ensure that there are no duplicate entries in 'depends'
      (I couldn't find the root cause for duplication, so I just
      put the test here.)
    • Edward Z. Yang's avatar
      allLibModules now includes every signature in the package · 2515cc28
      Edward Z. Yang authored
      These may NOT be explicitly specified in the Cabal file;
      we read it off of 'componentInstantiatedWith'.
    • Edward Z. Yang's avatar
      Use the new Backpack code for the configure step · 688b31e3
      Edward Z. Yang authored
      Many of the configure functions were factored out and moved to the new
      Backpack modules. The new configure action makes a call to
      Distribution.Backpack.Configure to setup the ComponentLocalBuildInfo.
      Also add an @--instantiate-with@ flag to ./Setup configure, so that
      cabal-install can specify how it wants to instantiate a package that
      it is building.
      Also do the minimal necessary adjustments in cabal-install.
    • Edward Z. Yang's avatar
      Add the bulk of the new Backpack code · f2840cca
      Edward Z. Yang authored
      This will shortly be used in the package configuration step.
          A copy of the Progress monad from cabal-install solver, which we use
          to report failure and logging from otherwise pure code.
          Defines a type class ModSubst for semantic objects that can have
          module substitutions defined over them.  Helps us define ModSubst
          A module scope represents the set of required and provided modules
          which are "in scope", i.e., available for import and mix-in linking.
          This is not a simple mapping from module name to module, as we're
          permitted to have conflicting definitions for a module name as long
          as we don't actually use it.  There's a comment which explains this
          more clearly in the file.  These are based off of 'IndefModule'
          because not all modules in scope are necessarily fully instantiated.
          A module shape describes the provisions and requirements of a
          library.  It's similar to a module scope, except that every
          export must be unambiguous; it too is based off of 'IndefModule'.
          An 'IndefUnitId' is not guaranteed to record a module substitution
          (it could be opaquely represented as a hash); a 'FullUnitId',
          however, IS guaranteed to do so.  Given, for example, an installed
          package database, we can map opaque 'UnitId' into their expanded
          representation.  This can be important to handle obscure unification
          problems when mix-in linking.
          The unification monad, unifiable variants of Module/UnitId (with
          conversions to and from), and low-level unification operations on
          them.  Uses 'UnionFind' heavily.
          There is some commented out support for handling recursive
          unification.  At present there is no surface syntax for representing
          such situations.  (We would also need DFA minimization to
          canonicalize these regular trees.)
          The actual implementation of mix-in linking, on top of the
          unification monad 'UnifyM'.  The key function is 'mixLink',
          which takes two module scopes and links them together.
          The progress monad, specialized with LogMsg traces and Doc
          errors.  We provide a function to run such computations,
          outputting traces according to their 'Verbosity' and 'die'ing
          if there is an error.
          A small helper function for handling the source-level graph
          of components (so, just the relationship between stanzas
          in a Cabal file.)  This components graph will eventually get
          elaborated into a more complex graph with instantiations, etc.
          A helper module which now contains the functions for computing
          component identifiers and compatibility package keys.  This
          functionality used to live in Distribution.Simple.Configure
          but I split it out.  There are also adjustments to handle
          the new Backpack functionality.
          A configured component is one for which we've resolved all
          source level dependencies (e.g., every entry in build-depends,
          we know the specific transitive versions of each thing
          we're going to use.)  That means we have a 'ComponentId' for
          this component.  This module also contains functions for
          creating a 'ConfiguredComponent' from a source 'Component'.
          A linked component is one which we have done mix-in linking
          for, so we know its 'IndefUnitId' and its 'IndefUnitId'
          This module calls out to mix-in linking to actually do linking.
          The workhorse, in a sense!
          This module implements the instantiation process, where we
          zip through all of the fully instantiated components, and
          recursively instantiate their dependencies, so that we
          get a separate linked component per thing we need to
          compile, and also finishes off any top-level indefinite
          components.  This gives us the final 'UnitId' for our
          This functionality is reimplemented in a different way in
          cabal-install; the assumptions are slightly different (in
          particular, in the library we can't assume we have access to all
          packages to build them; but in cabal-install we can assume it) so I
          didn't try to abstract over both implementations.
          This is a "interoperability" data type which identifies
          precisely the information from a 'LinkedComponent' that
          can be derived from an 'InstalledPackageInfo'.
    • Edward Z. Yang's avatar
      Extend ComponentLocalBuildInfo with backpack info · be1a184c
      Edward Z. Yang authored
      (1) add 'componentInstantiatedWith' to record how a component was
      instantiated (analogous to @instantiated-with@) and
      (2) fix 'componentComponentId' for the new constructors in 'Module'.
    • Edward Z. Yang's avatar
      Replace the module renaming/thinning system · 1017f710
      Edward Z. Yang authored
      We had an old implementation of 'ModuleRenaming', with the
      assumption that it would be used directly in build-depends; since
      we have dropped this assumption, we can refactor 'ModuleRenaming'
      and we do so.  The main idea is to make the data type more directly
      reflect the syntax you can specify in a Cabal file; so the default
      renaming and an explicit thinning renaming are now different
      constructors.  It's no longer possible to use the "with" syntax, but
      it's not necessary either, since we have a special backpack-includes
      field to specify renamings, so we don't need them to be Monoidal.
      There is also a new syntax for 'hiding', which just lets you hide
      some modules when including a package. Handy!
      Previously, we recorded 'ModuleRenaming' in @build-depends@, but
      separated it out when we stored in 'BuildInfo'.  We now go even
      further, by changing it from a 'Map' (the only thing @build-depends@
      could support) to a list (so that a package name can be specified
      multiple times.)  This is good because now a user can instantiate
      something several times, which is useful in Backpack.
      Also add the new field @backpack-includes@ which can be used to exert
      fine-grained control over what modules a package brings into scope,
      include it multiple times, etc.
      In the .cabal checks, replace 'depsUsingThinningRenamingSyntax' with a
      more direct check to see if @backpack-includes@ was used.
      Dropped the legacy 'lookupRenaming' export from ModuleRenaming and
      PackageDescription; we will shortly not use it anymore. As an
      intermediate hack we have a local definition in Configure, but this
      will go away shortly.
    • Edward Z. Yang's avatar
      Rename .cabal required-signatures field to signatures · 8d31f43b
      Edward Z. Yang authored
      Change of .cabal file syntax: rename @required-signatures@ field to
      just @signatures@. Update the parser and error messages that mention
      the field.
      Also rename the corresponding field in the Library type.
    • Edward Z. Yang's avatar
      Backpack InstalledPackageInfo representation changes · 3de0e4c4
      Edward Z. Yang authored
      New field, @instantiated-with@, which records the full
      module substitution (it is dropped when we do 'improveUnitId').
      For flexibility in the case of indefinite packages, some
      occurences of Module are relaxed to IndefModule (exposedReexport).
      This is just for convenience; in the case of a definite package
      these reexports and instantiations are guaranteed to be 'Module's.
      This patch also includes the minimal changes in other modules
      needed due to the representation change.
    • Edward Z. Yang's avatar
      Support for GHC flags -instantiated-with and -fno-code · 305935d9
      Edward Z. Yang authored
      New GhcOptions fields, 'ghcOptInstantiatedWith' for
      @-instantiated-with@ and 'ghcOptNoCode' for @-fno-code@.
    • Edward Z. Yang's avatar
      Update GhcOptions to use IndefUnitId for -package-id · 5b378e48
      Edward Z. Yang authored
      We will use this when building indefinite libraries.
    • Edward Z. Yang's avatar
      Add D.Backpack module with IndefUnitId and IndefModule types · fdf30f80
      Edward Z. Yang authored
      This module defines the key data types 'IndefUnitId' and
      'IndefModule', which represent components which are partially
      instantiated with holes in them.  The intent is that they
      can be substituted over (Distribution.Backpack.ModSubst),
      and once all the holes are filled they can be improved into
      proper 'UnitId's, which can then be installed.
      Also add Distribution.Util.Base62 module containing an
      implementation of base-62 encoding, which we use when
      computing hashes for fully instantiated unit ids.
    • Edward Z. Yang's avatar
      Introduce the new representation of UnitId · d7bd9078
      Edward Z. Yang authored
      'SimpleUnitId' constructor renamed to 'UnitId', and augmented
      with a new field 'Maybe String' recording a hash that uniquely
      identifies an instantiated unit of the library 'ComponentId'.
      'UnitId' can't be used to represent partially instantiated
      unit identifiers; see Distribution.Backpack for how we handle that.
      Previous uses of 'SimpleUnitId' should now use 'newSimpleUnitId'.
      'unitIdComponentId' folded into a record selector for 'ComponentId'.
    • Edward Z. Yang's avatar
      Add a parser for 'key' field of InstalledPackageInfo · cbc1a1de
      Edward Z. Yang authored
      Rather than reusing the one for ComponentId.
    • Edward Z. Yang's avatar
      A minor improvement to convenience libraries · 7637d067
      Edward Z. Yang authored
      We force convenience libraries to NOT be exposed (they're private,
      after all.)  This will help us on some of our test cases.
    • Edward Z. Yang's avatar
    • Edward Z. Yang's avatar
      Update 'getHaskellObjects' to take 'ComponentLocalBuildInfo' · 9e8fea3e
      Edward Z. Yang authored
      Eliminating the use of deprecated 'getComponentLocalBuildInfo'
    • Edward Z. Yang's avatar
    • Edward Z. Yang's avatar
    • Edward Z. Yang's avatar
      Add more reexported module tests · 6059c6b3
      Edward Z. Yang authored
      Signed-off-by: default avatarEdward Z. Yang <>
    • Edward Z. Yang's avatar
    • Edward Z. Yang's avatar
      Ignore cabal.project.local · be218c72
      Edward Z. Yang authored
      Signed-off-by: default avatarEdward Z. Yang <>
    • Edward Z. Yang's avatar
      Merge pull request #3942 from 23Skidoo/issue-3938 · ff08346c
      Edward Z. Yang authored
      cabal.project: Add a constraint on unix.
    • Mikhail Glushenkov's avatar
      Fix CI on Mac OS X with GHC 7.8 and earlier. · 2ed454ee
      Mikhail Glushenkov authored
      On recent OS X, Cabal does not work correctly because it assumes
      that a permission denied error when reading permissions on
      executables, resulting in errors like "Setup: /usr/bin/ar: permission denied".
      The proximal fix for this is to add a constraint on unix when we build
      Cabal/cabal-install to avoid building with the buggy version of unix.
      But this causes other problems:
      - Bumping the version of unix means that our local build of Cabal
        will depend on things from the store.  But we weren't passing
        this to GHC when compiled Setup.hs for Cabal's package-tests.
        Set CABAL_PACKAGETESTS_DB_STACK env var explicitly to point
        to the right locations.
      - The new configuration of versions exposed some bugs in some
        macro expanded code in cabal-install; we qualified those
        imports to squash unused warnings.
      - The cabal-install integration-tests occasionally use Cabal from
        the system GHC.  Since this will never work on OS X, we just
        skip the tests in those cases.
      Signed-off-by: default avatarEdward Z. Yang <>
  2. 05 Oct, 2016 2 commits
  3. 04 Oct, 2016 2 commits