GitLab

This was the pre-globstar behaviour; now it is tested and documented.

Before, we were walking the directory tree recursively
unconditionally. Now we check if the pattern is recursive before doing
that, and also only check the directory's full listing if a glob
pattern is involved at all, so literal patterns are more efficient.

I fixed this in passing with #5284, but let's add a test to make sure
it stays fixed. The error message isn't perfect, but it's a lot better
than failing silently!

Closes #5195.

Signed-off-by: Edward Z. Yang <ezyang@cs.stanford.edu>

Signed-off-by: Edward Z. Yang <ezyang@cs.stanford.edu>

This should work on OSX, and even though grabbing it from the bsdgames
package ought to have worked on Linux, it apparently didn't, so let's
try this instead.

Signed-off-by: Edward Z. Yang <ezyang@cs.stanford.edu>

PR #5284 changed things around, and now matchDirFileGlob will break if
it's passed a null directory, which happens to be the default value
for data-dir. Its call sites have been fixed to check for this and to
substitute '.' for an empty path, which is the desired behaviour; in
addition, matchDirFileGlob itself will now warn about this if it's
detected, so that new broken call sites can't sneak in.

Fixes #5318.

Looks like this was forgotten - it is done in GHC but not in Cabal.

c.f. #3700

[ci skip]

This commit generalizes the fix for issue #4781
(e86f8389) by tracking dependencies on
components instead of dependencies on executables.  That means that the solver
always checks whether a package contains a library before using it to satisfy a
build-depends dependency.  If a version of a package doesn't contain a library,
the solver can try other versions.  Associating each dependency with a component
also moves towards the design for component-based dependency solving described
in issue #4087.

The solver DSL previously always added a default library component.

This change allows the solver quickcheck tests to test all types of components.
Previously, the tests generated the components in the solver DSL, but the code
that converted the packages to GenericPackageDescriptions removed some of the
components, i.e., it filtered out benchmarks and foreign libraries and merged
internal libraries with the main library.

I disabled one test that still fails on Windows:
PackageTests/NewBuild/CustomSetup/RemotePackageWithCustomSetup/build-package-from-repo-with-custom-setup.test.hs