Signed-off-by: Edward Z. Yang <ezyang@cs.stanford.edu>

Signed-off-by: Edward Z. Yang <ezyang@cs.stanford.edu>

This is an omnibus patch, with the overall goal of making
LocalBuildInfo Great Again.  The essential ideas:

* New type 'TargetInfo' which bundles together 'ComponentLocalBuildInfo'
  and 'Component'.  Eventually, it will also record file paths / module
  targets.  This data structure is basically what you want; a lot of
  old Cabal code did lots of gyrations converting from
  'ComponentLocalBuildInfo' to 'Component' and vice versa, now
  it's all centralized.

* The "new" API for 'LocalBuildInfo' is in
  "Distribution.Types.LocalBuildInfo".  The general principle
  is, where we previous dealt in 'ComponentLocalBuildInfo',
  we now deal in 'TargetInfo'.  There are shockingly few
  functions we need!

* I've restored 'componentsConfigs' to its Cabal 1.24 signature
  for BC.

* I killed a number of unused functions from "Distribution.Simple.LocalBuildInfo":
  'getLocalComponent', 'maybeGetDefaultLibraryLocalBuildInfo',
  'maybeGetComponentLocalBuildInfo', 'checkComponentsCyclic' and
  'enabledComponents'.  For each I checked on Hackage that they were
  not used.

* 'getComponentLocalBuildInfo', 'withComponentsInBuildOrder' and
  'componentsInBuildOrder' are deprecated to encourage people
  to instead use the 'TargetInfo's to finger which components
  they want built.

* 'ComponentLocalBuildInfo' now stores internally the computed
  'componentInternalDeps', so that 'LocalBuildInfo' can simply store
  a graph of 'ComponentLocalBuildInfo'.

* The code in Configure has been streamlined to use our new Graph
  data type to great success.

* The type of 'runTest' changed to take a 'ComponentLocalBuildInfo',
  bringing it more in line with everything else.

* New function 'readTargetInfos' which combines 'readBuildTargets'
  and 'checkBuildTargets', which is what you really wanted anyway.

Signed-off-by: Edward Z. Yang <ezyang@cs.stanford.edu>

Restore autogenModulesDir to BC-compatible signature

autogenModulesDir's proper name is autogenPackageModulesDir, and
it's an autogenerated file directory that applies to ALL
components in the package.  It lives in 'global-autogen'.

Signed-off-by: Edward Z. Yang <ezyang@cs.stanford.edu>

Signed-off-by: Edward Z. Yang <ezyang@cs.stanford.edu>

Check that all internal libraries have a name.

Remove dead code

It seems that package authors are often unaware of the purpose of
synopsis/description fields, and their impact on cabal and Hackage.  A
common mistake is to write a verbose synopsis and leave the description
field empty or even worse with useless boilerplate-text filled in by
tooling, resulting in a suboptimal presentation on Hackage.

The `synopsis` is supposed to be a terse <80 char description. In fact,
the cabal user's guide states:

> A very short description of the package, for use in a table of
> packages. This is your headline, so keep it short (one line) but as
> informative as possible. Save space by not including the package name
> or saying it’s written in Haskell.

On Hackage this synopsis is printed in the `<title>` and at the top of the
package page, and is difficult to spot. However, the synopsis is
displayed on Hackage in package lists or search results.

On the other hand, the `description` field is rather important for
`cabal info`  as well as the package cover-page, as it's printed below
the "The $PKGNAME package"-heading, and above the properties section,
and that's where everyone looks at.

This new lint check is an attempt to point out a suspiciously short
description field by using the heuristic of expecting the description
field to be longer than the synopsis.

Removing 'topdown' as a resolver choice means that 'choose' is also
obsolete and so it is removed too.

This implements the flag `--allow-older` which is the analogous to
`--allow-newer` acting on lower bounds.

Pretty utils

Remove setup-dev.sh since it is no longer necessary post-new-build.

[ci skip]

[ci skip]

Consistently update 'localPkgDescr' with 'HookedBuildInfo' + docs

I got sucked into this rathole while puzzling over why
we pass both 'PackageDescription' and 'LocalBuildInfo' (which
has a 'PackageDescription' in 'localPkgDescr').  The conclusion
is that they were different, but not for a good reason. Now they're
the same.

Added docs fixes #1757.

Signed-off-by: Edward Z. Yang <ezyang@cs.stanford.edu>

1. Unbreak the deployment script (hopefully the last time).
2. No longer attempt to upload docs when building from non-main repos.

Fixes #3592.

Explode Distribution.PackageDescription into many Distribution.Types modules

This commit explodes Distribution.PackageDescription and
Distribution.Simple.LocalBuildInfo into many Distribution.Types modules.

Signed-off-by: Edward Z. Yang <ezyang@cs.stanford.edu>

Signed-off-by: Edward Z. Yang <ezyang@cs.stanford.edu>

BC fix: libraries -> library/subLibraries (#3574)

The resulting code is more verbose, but it is more backwards-compatible
and actually is simpler to understand in some cases (because
CLibName uniquely identifies the "public library"; no faffing
about with package names to figure it out.)

Signed-off-by: Edward Z. Yang <ezyang@cs.stanford.edu>

Signed-off-by: Edward Z. Yang <ezyang@cs.stanford.edu>

Introduce new ComponentEnabledSpec, removing testEnabled/benchmarkEna…

Test bootstrap on OSX.

Signed-off-by: Edward Z. Yang <ezyang@cs.stanford.edu>

The command 'new-build' won't be completed, but if you type it out
you'll get completions from that point.

Signed-off-by: Edward Z. Yang <ezyang@cs.stanford.edu>