GitLab

Add a lower bound of >= 1.18. Also improve the related comments.

Using >= 1.18 since we currently have problems working with 1.16 as that
version lacks support for named build targets. We ought to fix working
with older versions though.

Add transformers and old-time, and for ghc-compatible compilers also add
ghc-prim and template-haskell.

Have to double check if the old-time dep needs to be conditional, e.g.
on ghc version.

Signed-off-by: Edward Z. Yang <ezyang@cs.stanford.edu>

Unfortunately, it was too difficult to factor out the common code
between ProjectBuilding and Install.
Signed-off-by: Edward Z. Yang <ezyang@cs.stanford.edu>

Signed-off-by: Edward Z. Yang <ezyang@cs.stanford.edu>

Signed-off-by: Edward Z. Yang <ezyang@cs.stanford.edu>

Signed-off-by: Edward Z. Yang <ezyang@cs.stanford.edu>

This commit looks somewhat bigger than it is because I moved some comments
around so we can have longer comments for the constructors. The most important
change is the documentation of the `QGoalReason` invariant on 'GoalChoice'.

This commit doesn't change any actual code.

OpenGoal contains a FlaggedDep which contains a lot more information than we
actually need in the tree; we just need to know, which choice are we
introducing: package, flag, or stanza? We don't need the full FlaggedDep tree.

Pkg-config constraints are actually a part of 1.24.

This field is only added if the `debug-conflict-sets` flag is specified to
`cabal config`; it adds a tree to `CallStack`s to a `ConflictSet`. This is very
useful when trying to understand how a certain conflict set was constructed.

This makes it a bit easier to modify it (for example, during debugging).

Fixes #3390.

(cherry picked from commit 6f3a3e59)

Getty Ritter authored May 02, 2016 and Mikhail Glushenkov committed May 03, 2016

An outstanding bug in GHC pre-8 causes haddock comments on GADT constructors to fail, which in turn prevents the bootstrapping process from finishing. This works around it by skipping haddocks for hackage-security.

(cherry picked from commit 02a313e9)

The plainHttpTransport implementation saved the resulting file only when the
server responded with 200 OK, thus ignoring the payload from the server when
the server responded with a 206 Partial Content. This was causing incremental
updates through hackage-security to fail (it wouldn't fail fatally;
hackage-security would notice the invalid timestamp and download the whole
thing instead, but of course this means we're not actually getting any
incremental behaviour).

The bash completion suffers from a number of issues,
some fix with this patch;

With this patch we expand the path to cabal as well as its arguments.
For example;
~/code/cabal configure --with-ghc=$GHC <tab><tab>
will now work. Both ~ and the $GHC variable will be expanded.

If there are no .cabal files, or multiple files, the script will no longer
crash.

We still invoke cabal to get completions. If cabal detects an error and writes
errors to STDERR, these will no longer be printed to the console. Instead we
don't offer any completions.

See https://github.com/haskell/cabal/commit/978c083abdb72d5760ab271c5079df66dbdc7647#commitcomment-17241967.

This should address #2956 and is motivated by #3378

[ci skip]