GitLab

Previously, we were checking the package with a hard-coded root
directory of ".". This was not a problem before, but with #5372 we
have started to expand globs while checking packages, which breaks if
the CWD is not the directory containing the `.cabal` file and causes
snowleopard/hadrian#634.

Luckily, this is an easy fix: the correct directory is easy to
determine. Writing a test and making sure it's tickling the failing
case took longer than writing the fix!

"." is hard-coded as the root directory passed to `checkPackageFiles`
in a few other places, but those are (a) non-trivial to test, and (b)
already in places that have other assumptions about their CWD, so I
have simply documented the CWD requirement for those.

It's non-obvious that the expected way to pass command line options to
a test suite would be a different command, so mention it explicitly.

Closes #5416.

7.4 is out of our support window, so it's not really important to consider for the status of a PR (and can contribute to error fatigue)

Lexically, they're identical to 2.2, but the semantics of globs have
changed slightly.

quasicomputational authored Jun 27, 2018 and Mikhail Glushenkov committed Jun 28, 2018

jgm/zip-archive#47 has been merged and released as part of 0.3.3, so
there is now no need to grab old-time and old-locale in booststrap.sh.

quasicomputational authored Jun 27, 2018 and Mikhail Glushenkov committed Jun 28, 2018

This was only a convenience function, but its use could obscure how it
is introducing a dependency on the CWD. By removing it, the "."
argument to `matchDirFileGlob` is explicit.

Any external code using `matchFileGlob` would have needed to be
changed as #5284 changed its signature and the module it lives in; it
is not much more of a burden to switch to `matchDirFileGlob` at the
same time.

quasicomputational authored Jun 27, 2018 and Herbert Valerio Riedel committed Jun 27, 2018

As suggested in #5401.

[skip ci]

y[ci skip]

[ci skip]

[ci skip]

Strip empty arguments lists from the elabProgramArgs in
ElaboratedConfiguredPackage to eliminate spurious configuration changes being
found.

Move package flag normalisation code for the new-build hash into it's own
`normaliseConfiguredPackage` function and reuse it to detect whether the
configuration of a local package has changed and needs to be rebuild.

It was being properly wrapped when the command was invoked, but not
for --help output. Hard-wrapping is unfortunate but it's the best we
can do in this scenario; it's better than the previous manual
wrapping, at least.

We don't need to hard-wrap the message as we originate it, since
that's handled elsewhere.

quasicomputational authored Jun 21, 2018 and Alexis Williams committed Jun 24, 2018

The code does the right thing, but it's slightly fragile since it
depends on directory switching, so make sure it stays right.

quasicomputational authored Jun 21, 2018 and Alexis Williams committed Jun 24, 2018

This one wasn't actually testing what it said it was testing. Oops.

quasicomputational authored Jun 20, 2018 and Alexis Williams committed Jun 24, 2018

They're not all passing, but I think that that's a bug in the code
rather than the tests.

quasicomputational authored Jun 20, 2018 and Alexis Williams committed Jun 24, 2018

[ci skip]

quasicomputational authored Jun 20, 2018 and Alexis Williams committed Jun 24, 2018

[ci skip]