This project is mirrored from Pull mirroring updated .
  1. 30 Jul, 2016 1 commit
    • kristenk's avatar
      Avoid filtering the solver log before 'showMessages'. · f2d02983
      kristenk authored
      Previously, the solver filtered out redundant backjumping messages twice, once
      in 'Log.logToProgress' and again in 'Message.showMessages. However,
      'showMessages' relied on the backjumping messages to determine where to insert
      messages about missing packages. This led to missing "unknown package" messages
      (part of issue #3617).
      This commit removes the filtering in 'logToProgress', because it was redundant.
  2. 16 Jul, 2016 1 commit
  3. 04 Jul, 2016 1 commit
  4. 03 Jul, 2016 3 commits
  5. 27 Jun, 2016 4 commits
  6. 07 May, 2016 1 commit
  7. 26 Apr, 2016 1 commit
  8. 24 Apr, 2016 1 commit
  9. 23 Apr, 2016 1 commit
  10. 22 Apr, 2016 3 commits
    • Andres Löh's avatar
      Allow to test error messages in the solver tests. · 268edadb
      Andres Löh authored
      Added this so that we can verify the unknown package error.
    • Andres Löh's avatar
      Add the current goal to the initial conflict set while backjumping. · 018e9365
      Andres Löh authored
      This is relevant for unknown packages. Without the current
      goal in the initial conflict set, the unknown package itself
      does not end up in its own conflict set.
      But we want it to, if only to make sure that the error slicing
      machinery keeps the message about the unknown goal around.
      It is also the correct thing to do. The initial conflict set
      corresponds to a virtual "avoid" choice underneath the package
      goal. That choice corresponds to avoiding assigning any proper
      value to the goal at all, which might be possible if the goal
      was not needed. The conflict set for this "avoid" goal is always
      between the current package and its immediate goal reason.
      I have added comments to the code explaining this as well.
    • Andres Löh's avatar
      Add two more solver test cases. · 162d2580
      Andres Löh authored
  11. 21 Apr, 2016 3 commits
    • kristenk's avatar
      Use larger conflict set when solver chooses wrong version for package in link group · 7f480594
      kristenk authored and Edsko de Vries's avatar Edsko de Vries committed
      This commit replaces a call to 'lgBlame' with a call to 'lgConflictSet'.
      'lgConflictSet' adds the members of the link group to the conflict set. The
      other members are required, for example, when a linked package's version doesn't
      match a constraint, and the solver must try other versions for the linked-to
      All tests now pass.
    • Edsko de Vries's avatar
      Declare indepGoals3 as passing. · 440033d6
      Edsko de Vries authored
    • Edsko de Vries's avatar
      Use empty POption for unknown packages · 5a4149f4
      Edsko de Vries authored
      and fix the error message in showMessages; this keeps the construction of
      conflict sets uniform.
      This still isn't quite right though. If we remove B from db21 as well, we don't see a line "unknown package B" appearing in the log. I have no idea why.
      Also, @kosmikus says:
      > ok, so first problem: we still need to add C to the conflict set
      > one way to do this now is to change the "initial" conflict set in the backjump calls to be the node + the goal reason again
      > I was assuming that the initial set is only ever added to an existing conflict set that we already have
      > but this is now no longer true
      I have no idea what that means :)
  12. 20 Apr, 2016 1 commit
  13. 18 Apr, 2016 11 commits
  14. 17 Apr, 2016 3 commits
  15. 13 Apr, 2016 1 commit
  16. 03 Apr, 2016 1 commit
    • kristenk's avatar
      Simplify representation of test suites in the solver DSL · 931b5a19
      kristenk authored
      This commit removes the 'ExTest' constructor from 'ExampleDependency'.
      Test dependencies are now represented using the same
      'ExampleDependency' constructors as library dependencies.  The only
      difference between dependencies of different components is that they
      are placed under different keys in 'D.C.ComponentDeps.ComponentDeps'.
  17. 31 Mar, 2016 1 commit
  18. 29 Mar, 2016 1 commit
  19. 12 Mar, 2016 1 commit
    • Edsko de Vries's avatar
      Change structure of package paths · 3d2ad8e0
      Edsko de Vries authored
      A package path now consists of a namespace and a qualifier. The namespace is
      either DefaultNamespace or Independent _i_, for some _i_; this is used for
      independent top-level goals. Then the qualifier is either Unqualified
      (default), Setup _pn_ for the setup dependencies of package _pn_, or Base _pn_,
      for a dependency on base by package _pn_ (used only when we detect the presence
      of a base shim). Qualifiers are not tested anymore.
      This avoids non-termination in the solver. The unit tests now pass.