GitLab

To allow parsers & pretty-printers for extensions of the format.

Otherwise we cannot use '{' '}' chars in field contents, as they
get interpreted as layout syntax. We want this for things like:
  library-dirs: ${pkgroot}/../libfoo/

The description is already included. The one-line synopsis should be
there too. Note that this is an API change that will affect compilers.

The old one was always too generic and it now contrasts
better with the new installedPackageId field.

  
  NOTE: the patch has been split into 9 pieces for easy
  reviewing, the individual pieces won't build on their own.
  
Part 1 does the following:

Distribution.Package: 
  - define the InstalledPackageId type as a newtype of String

Distribution.InstalledPackageInfo:
  - add an installedPackageId field to InstalledPackageInfo
  - change the type of the depends field from [PackageIdentifier]
    to [InstalledPackageId]


The idea behind this change is to add a way to uniquely identify
installed packages, letting us decouple the identity of an installed
package instance from its package name and version.  The benefits of
this are

  - We get to detect when a package is broken because its
    dependencies have been recompiled, or because it is being
    used with a different package than it was compiled against.

  - We have the possibility of having multiple instances of a
    given <package>-<version> installed at the same time.  In the
    future this might be used for "ways".  It might also be
    useful during the process of upgrading/recompiling packages.

Using the new utils in ParseUtils.

Put the arguments in a more sensible order:
ppFields :: [FieldDescr a] -> a -> Doc
and make the implementation clearer.
clean up the use of it in the PackageDescription.Parse module

Use cabal-devel@haskell.org as the maintainer in most cases except for
a few which were pre-existing modules copied from elsewhere or modules
like L.H.Extension which really belong to libraries@haskell.org
Remove the useless stability module. We have more detailed information
on stability elsewhere (in the version number and user guide).
Add more top level module documentation, taken from the source guide.

We want to allow case-insensitive parsing however we don't want
packages being uploaded to hackage that will break older versions of
Cabal. If we allow new valid parses then we will end up breaking
stuff. So what we really want to do is allow new parses but warn if
they're not ones that older versions of Cabal would have allowed. So
long as hackage rejects pakcages that have parse warnings then we can
prevent new .cabal files appearing on hackage that would break older
Cabal versions. Our current parser (ReadP) does not support warnings
so we have to handle the bool fields specially in the parser wrapper
layer that we added to handle errors and warnings. This can go away
when we use a parser with support for error and warning messages.

One use was for parsing bools in the installed package info. We can
go with the more liberal Text instance for that. The other use is for
parsing Haskell strings in quoted string fields. So we keep it for
that purpose but restrict the type and rename to parseHaskellString.

Initially it's exactly the same format as Read/Show.
We can make it more liberal later.

And change all uses.

The instance for Version is in the Text module itself because the
Version type is defined in base. This avoids an orphan instance.

(pkgName . packageId) and (pkgVersion . packageId)
turn out to be very common so give them names.

rather than just PackageIdentifier. This will enable us to do lots more in
future, for example detecting inconsistent package depends, doing our
own cpp pre-processing or module chasing.

and stop exporting various internal stuff from PackageDescription.Parse
which was previously being used by the sanity checking code.

This is useful in GHC, we can instantiate InstalledPackageInfo to
ModuleName and avoid lots of String<->FastString conversions.

Here are a batch of refactorings to clean up parsing and parts of the
simple build system.  This patch originated in a patch sent to
cabal-devel@haskell.org with an intial implementation of
configurations.  Since then we decided to go a different route with
configurations, so I have separated the refactoring from the
configurations patch.

At this point, 2 tests fail for me, but I get the same 2 failures
without this patch.

This patch is sponsored by Hac 07.
Have you hacked a lambda today?

  No reason we shouldn't have Ord on PackageIdentifiers

  Various changes committed in one bunch:
  
   - bindir/libdir/datadir/libexecdir support as discussed on
     librarie@haskell.org.  This should be considered fairly
     experimental.  Full documentation in the manual.
  
   - A module Paths_<pkgname> is autogenerated, you should be able
     to just import this.  (I haven't made this work with Hugs yet, though).
     I suspect I might need to make sure it's available to 'setup haddock'
     too.  Also, I haven't tested this on Windows yet (TODO).
  
   - All installation-paths-related functions are now provided by
     Distribution.Simple.LocalBuildInfo
  
   - some cleaning up of Distribution.Simple.Build as regards GHC support.
  
   - "setup copy" now takes a --destdir argument instead of --copy-prefix
     (the latter is still accepted for compatibility).
  
     Note for autoconf/make users: this means that your Makefile now
     needs to implement a "copy" target, see the manual for details.
  
   - New types: Distribution.Setup.CopyFlags (was previously just a
     pair), and CopyDest (was previously Maybe FilePath).
  
   - Hooks: the post hooks all take a PackageDescription argument now.
     There seemed no reason not to do this, and sometimes it's useful.


  Remove literal tabs in strings.  Not Haskell'98.

  harmonize running of ./confugure between defaultUserHooks and
  Distribution.Make:
  
  * pass through the same set of flags, plus unrecognized options
  
  * select the default compiler before processing options

  Fixes for Windows

  added a simple-minded data-files field.  Also added getDataFileName to
  Paths_<pkg> to save client code from worrying about path separators.

  documentation updates from ross paterson
  - more accurate specification of package names
  - hs-source-dir -> hs-source-dirs in examples
  - setup clean removes a bit more
  - rearrange description of fields

  Version.hs: allow more spaces in version constraints

  Install.hs: add the exe extension when installing executables (reported by Brian Smith)
 
  test directory: add explicit dependencies on base

  Misc:
  Prefix error messages and warnings with the program name, and send them
  to stderr.  (Also moved some stuff from Distribution.Simple.Utils to
  Distribution.Simple.Build to avoid circular dependencies.)

  refactoring only: split Compiler type from Distribution.Setup,
  to reduce dependencies.

  Exclude DefaultSetup.lhs from the GHC build

  add JHC to the Compiler type

  refactored argument processing

  setup sdist --snapshot: append YYYYMMDD to the version for the bundle

  improved error messages (from Brian Smith):
  
  * attach source locations to messages when available
  
  * change some remaining error's do die.

  refactor defaultMainWorker

  split Distribution.Extension between Language.Haskell.Extension (just
  the type, which will also be useful when haskell-src-exts is merged)
  and Distribution.Compiler (mappings to compiler options).

  add Language.Haskell.Extension

  Simon marlow:  update defaults for prefix/libdir/bindir

  Clean up parsing & pretty-printing.
  
  Most list fields now have consistent syntax:
  
    - commas are optional
    - each element of the list is either
  	- a sequence of one or more non-space non-comma characters
  	- a quoted string in Haskell 98 lexical syntax
  
  The build-depends field still requires commas, because the elements
  can contain whitespace.
  
  I merged fieldGet/fieldShow in StanzaField into a single field for
  simplicity.