GitLab

Visibility field

- for main library default is True
- for named libraries default is False
- remove Monoid Library instance; i'd rather remove emptyLibrary too
  but now these (two?) usages are explicit:
  - creating Library from BuildInfo when merging common stanzas
  - creation of dummy package in `cabal new-repl`
- Documentation is left for Francesco to write
- Field is named `visible` because we have `buildable` and `exposed`
  adjectives. `visibility: True` is unclear.

Move remainders of ReadP stuff to cabal-install Distribution.Deprecated namespace

- Distribution.Compat.ReadP to Distribution.Deprecated.ReadP
- Distribution.Text to Distribution.Deprecated.Text
- all Text instances needed by cabal-install to Deprecated.Text too
- Distribution.ParseUtils to Distribution.Deprecated.ParseUtils
- Remove deprecated Distribution.PrettyUtils
- new Distribution.Text with

    display = prettyShow
    simpleParse = simpleParsec

  to not break too much stuff (Custom Setup.hs)
- parseInstalledPackageInfo type signature changed to use
  `base` types

This removes around 2k lines from Cabal the library.
git diff --stat shows less, as files are moved (git is smart).
Even so, total 300 lines removal at this point.

Make CabalSpecVersion complete

Fancy error printing

Remove Text from D.BackPack

Empty and non-empty lines

```
Errors encountered when parsing cabal file ./tree-diff.cabal:

tree-diff.cabal:102:7:
unexpected 'n'
expecting space, "&&", white space, "||", comma or end of input

   98 |       void               >=0.7.2    && <0.8
   99 |
  100 |       -- space and comments
  101 |
  102 |       nats               >=1.1.1    && <1.2,
      |       ^

tree-diff.cabal:86:48: version with tags

   85 |     tagged               >=0.8.5    && <0.9,
   86 |     text                 >=1.2.2.2  && <1.3-foo,
      |                                                ^

```

Improve printing of errors of parsing .cabal files even further

Don't record ORIGIN anymore, it's being cross-referenced.

This reverts commit 3c243455.

Remove Text from D.PackageDescription

- Separate the logic into own module
- Use same function in `cabal check` codepath
- Tweak the output a little more

Improve cabal file parse error messages.

Signed-off-by: Edward Z. Yang <ezyang@cs.stanford.edu>

See also 005d9121

Closes #5643

Resolves the non-vcs-related part of #5643

NB: this patch mostly moves around code; use
    `git show --ignore-space-change` to facilitate code-review

(cherry picked from commit c40622d4)

When creating an sdist, if the project is a remote source repo then
use the local directory if it is available.

This allows projects with remote source repos to use the v2-install
command.

Resolves: #5643
(cherry picked from commit 71b612c4)

Use Pretty (not Text) in D.P.Check

Improve the handling of .ghc.environment files

SDPX License List 3.3