Snippets Groups Projects

Fix repl discarding --build-depends (#8732)

Pierre Le Marre authored 2 years ago

* Fix repl discarding `build-depends` argument

Previously the function `\f -> L.allCondTrees $ traverseCondTreeC f` was
used to add the dependencies, but manipulating `CondTree` this way does
not update the nested fields `targetBuildDepends` of the tree, only the
conditions. It worked merely by chance if one does not further process
these fields: this explains why options like `--allow-newer` or
`allow-older` were incompatible with `--build-depends`.

Using `L.traverseBuildInfos . L.targetBuildDepends` ensures
`targetBuildDepends` fields and conditions are all updated consistently.

* Add test

* Add changelog

* Cleanup

---------

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
(cherry picked from commit e9b4744a)

7a619e60

7a619e60 2 years ago

Name	Last commit	Last update
.docker
.github
.gitlab
Cabal-QuickCheck
Cabal-described
Cabal-syntax
Cabal-tests
Cabal-tree-diff
Cabal
bootstrap
buildinfo-reference-generator
cabal-benchmarks
cabal-dev-scripts
cabal-install-solver
cabal-install
cabal-testsuite
changelog.d
doc
editors/vim
license-list-data
release-notes
solver-benchmarks
templates
.dockerignore
.git-blame-ignore-revs
.gitattributes
.gitignore
.gitlab-ci.yml
.mailmap
.readthedocs.yml
AUTHORS
CONTRIBUTING.md
LICENSE
Makefile
README.md
cabal.project
cabal.project.buildinfo
cabal.project.coverage
cabal.project.libonly
cabal.project.meta
cabal.project.release
cabal.project.validate
cabal.project.validate.libonly
cabal.project.weeder
fix-whitespace.yaml
generics-sop-lens.hs
ghc-packages
id_rsa_cabal_website.aes256.enc
release-checklist.md
stack.yaml
validate.sh
weeder.dhall

Cabal

This Cabal Git repository contains the following main packages:

Cabal: the Cabal library package (license)
Cabal-syntax: the .cabal file format library (license)
cabal-install: the package containing the cabal tool (license)
cabal-install-solver: the package containing the solver component of the cabal tool (license)

The canonical upstream repository is located at https://github.com/haskell/cabal.

Ways to get the `cabal-install` binary

GHCup (preferred): get GHCup using the directions on its website and run:
```
ghcup install --set cabal latest
```
Download from official website: the cabal-install binary download for your platform should contain the cabal executable.

Ways to build `cabal-install` for everyday use

With cabal-install: if you have a pre-existing version of cabal-install, run:
```
cabal install cabal-install
```
to get the latest version of cabal-install. (You may want to cabal update first.)
From Git: again with a pre-existing version of cabal-install, you can install the latest version from the Git repository. Clone the Git repository, move to its root, and run:
```
cabal install --project-file=cabal.project.release cabal-install
```
Bootstrapping: if you don't have a pre-existing version of cabal-install, look into the bootstrap directory.

Build for hacking and contributing to cabal

Refer to CONTRIBUTING.md.