This project is mirrored from Pull mirroring updated .
  1. 14 Mar, 2020 1 commit
  2. 04 Feb, 2020 1 commit
    • Ben Gamari's avatar
      Refactor waiting on job objects · 3138b775
      Ben Gamari authored
      Previously in order to wait on a job object we would create an IO
      Completion Port, configure the job object to emit notifications to it
      with SetInformationJobObject, and wait for JOB_OBJECT_MSG_EXIT_PROCESS
      notifications until all processes have died.
      This followed one piece of guidance from Microsoft [1] but according to
      Microsoft's own documentation, this cannot work reliably as delivery of
      job notifications is not guaranteed [2]. I have seen cases where the
      processes hang waiting on job objects so I can only guess that message
      loss is indeed possible.
      Instead we now take a simpler approach: look at the processes in the
      job, if there are none then we are done. If there are still processes,
      choose one and wait for it to finish. Iterate until the job is empty.
      Credit for this approach goes to Davean Scies.
  3. 12 Jun, 2018 1 commit
  4. 15 May, 2018 1 commit
  5. 03 Feb, 2017 1 commit
  6. 29 Jan, 2017 10 commits
  7. 23 Jan, 2016 1 commit
  8. 20 Jan, 2016 1 commit
  9. 02 Nov, 2015 6 commits