Skip to content
Snippets Groups Projects

Fix MulMayOflo for now

Closed Jaro Reinders requested to merge fix-mulmayoflo into master

Merge request reports

Pipeline #81204 failed

Pipeline failed for 54462d9d on fix-mulmayoflo

Closed by Jaro ReindersJaro Reinders 1 year ago (Aug 1, 2023 3:15pm UTC)

Merge details

  • The changes were not merged into master.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Jaro Reinders requested review from @mpickering

    requested review from @mpickering

  • Matthew Pickering enabled an automatic merge when the pipeline for 74a5b68e succeeds

    enabled an automatic merge when the pipeline for 74a5b68e succeeds

  • Jaro Reinders aborted the automatic merge because source branch was updated

    aborted the automatic merge because source branch was updated

  • Jaro Reinders added 1 commit

    added 1 commit

    Compare with previous version

  • Author Developer

    @mpickering the aarch64-darwin build will probably still fail as it does now with these errors:

    /var/folders/zj/qjrqljbj5mxcvj15mswcqhw40000hm/T/ghc68188_0/ghc_4.s:12:16: error:
         error: expected 'sxtx' 'uxtx' or 'lsl' with optional integer in range [0, 4]
                cmp x17, x17, sxtw
                              ^
       |
    12 |         cmp x17, x17, sxtw
       |                ^
    `gcc' failed in phase `Assembler'. (Exit code: 1)
    /var/folders/zj/qjrqljbj5mxcvj15mswcqhw40000hm/T/ghc68203_0/ghc_4.s:11:16: error:
         error: expected 'sxtx' 'uxtx' or 'lsl' with optional integer in range [0, 4]
                cmp x17, x17, sxtw
                              ^
       |
    11 |         cmp x17, x17, sxtw
       |                ^
    `gcc' failed in phase `Assembler'. (Exit code: 1)
    /var/folders/zj/qjrqljbj5mxcvj15mswcqhw40000hm/T/ghc68218_0/ghc_4.s:10:16: error:
         error: expected 'sxtx' 'uxtx' or 'lsl' with optional integer in range [0, 4]
                cmp x17, x17, sxtw
                              ^
       |
    10 |         cmp x17, x17, sxtw
       |                ^
    `gcc' failed in phase `Assembler'. (Exit code: 1)

    I think it should be generating:

    Edited by Jaro Reinders
  • Jaro Reinders assigned to @Noughtmare

    assigned to @Noughtmare

  • Author Developer

    I'll close this because it is being fixed upstream ghc!10970 (closed), ghc!10768 (closed).

    Edited by Jaro Reinders
  • closed

Please register or sign in to reply
Loading