From 502e6711a5c0a3f0e3ef53e7fd840694568eed68 Mon Sep 17 00:00:00 2001
From: Torsten Schmits <git@tryp.io>
Date: Mon, 4 Nov 2024 14:52:01 +0100
Subject: [PATCH] fix test lint that accumulated while the checks were broken
I didn't fix the issues flagged by the #ifdef linter because it were so
many that it seemed like the rule has become obsolete.
---
rts/IOManager.c | 2 +-
rts/Updates.h | 2 +-
testsuite/tests/bytecode/T24634/Makefile | 10 +++++-----
testsuite/tests/bytecode/T25090/Makefile | 14 +++++++-------
testsuite/tests/driver/Makefile | 2 +-
testsuite/tests/driver/boot-target/Makefile | 6 +++---
testsuite/tests/driver/fat-iface/Makefile | 2 +-
testsuite/tests/linters/regex-linters/check-cpp.py | 8 ++++----
testsuite/tests/perf/compiler/Makefile | 2 +-
9 files changed, 24 insertions(+), 24 deletions(-)
diff --git a/rts/IOManager.c b/rts/IOManager.c
index e05c099047f..4f53245dad6 100644
--- a/rts/IOManager.c
+++ b/rts/IOManager.c
@@ -364,7 +364,7 @@ void initIOManager(void)
* TODO: rationalise this into one entry point, that internally
* can do different things in the two cases.
*/
-#if defined (THREADED_RTS)
+#if defined(THREADED_RTS)
/* Win32 implementation in win32/ThrIOManager.c
*/
ioManagerStart();
diff --git a/rts/Updates.h b/rts/Updates.h
index 9bdc9d72c0a..7df978e96cf 100644
--- a/rts/Updates.h
+++ b/rts/Updates.h
@@ -9,8 +9,8 @@
#pragma once
#if !defined(CMINUSMINUS)
-#include "BeginPrivate.h"
#include "RtsFlags.h"
+#include "BeginPrivate.h"
#endif
diff --git a/testsuite/tests/bytecode/T24634/Makefile b/testsuite/tests/bytecode/T24634/Makefile
index b6bf36cc8c0..b08d2225048 100644
--- a/testsuite/tests/bytecode/T24634/Makefile
+++ b/testsuite/tests/bytecode/T24634/Makefile
@@ -4,14 +4,14 @@ include $(TOP)/mk/test.mk
# This case loads bytecode from the interface file written in the second invocation.
T24634a:
- $(TEST_HC) -c hello_c.c -o hello_c.o
- $(TEST_HC) -c -fbyte-code-and-object-code -fno-omit-interface-pragmas Hello.hs
- $(TEST_HC) -fprefer-byte-code -fbyte-code-and-object-code -fno-ignore-interface-pragmas hello_c.o Main.hs
+ '$(TEST_HC)' -c hello_c.c -o hello_c.o
+ '$(TEST_HC)' -c -fbyte-code-and-object-code -fno-omit-interface-pragmas Hello.hs
+ '$(TEST_HC)' -fprefer-byte-code -fbyte-code-and-object-code -fno-ignore-interface-pragmas hello_c.o Main.hs
./Main
# This case uses the bytecode generated in 'runHscBackendPhase', not involving the interface, since 'Hello' is compiled
# in the same invocation as 'Main'.
T24634b:
- $(TEST_HC) -c hello_c.c -o hello_c.o
- $(TEST_HC) -fprefer-byte-code -fbyte-code-and-object-code -fno-ignore-interface-pragmas hello_c.o Hello.hs Main.hs
+ '$(TEST_HC)' -c hello_c.c -o hello_c.o
+ '$(TEST_HC)' -fprefer-byte-code -fbyte-code-and-object-code -fno-ignore-interface-pragmas hello_c.o Hello.hs Main.hs
./Main
diff --git a/testsuite/tests/bytecode/T25090/Makefile b/testsuite/tests/bytecode/T25090/Makefile
index 41c71bfbc42..8729cfc5e10 100644
--- a/testsuite/tests/bytecode/T25090/Makefile
+++ b/testsuite/tests/bytecode/T25090/Makefile
@@ -4,18 +4,18 @@ include $(TOP)/mk/test.mk
# Verify that the object files aren't linked by clobbering them.
T25090a:
- $(TEST_HC) -c -fbyte-code-and-object-code C.hs-boot
- $(TEST_HC) -c -fbyte-code-and-object-code B.hs
- $(TEST_HC) -c -fbyte-code-and-object-code C.hs
+ '$(TEST_HC)' -c -fbyte-code-and-object-code C.hs-boot
+ '$(TEST_HC)' -c -fbyte-code-and-object-code B.hs
+ '$(TEST_HC)' -c -fbyte-code-and-object-code C.hs
echo 'corrupt' > B.o
echo 'corrupt' > C.o
echo 'corrupt' > C.o-boot
- $(TEST_HC) -c -fbyte-code-and-object-code D.hs
+ '$(TEST_HC)' -c -fbyte-code-and-object-code D.hs
echo 'corrupt' > D.o
- $(TEST_HC) -c -fbyte-code-and-object-code -fprefer-byte-code A.hs
- $(TEST_HC) -fbyte-code-and-object-code -fprefer-byte-code A.o -o exe
+ '$(TEST_HC)' -c -fbyte-code-and-object-code -fprefer-byte-code A.hs
+ '$(TEST_HC)' -fbyte-code-and-object-code -fprefer-byte-code A.o -o exe
./exe
T25090b:
- $(TEST_HC) -fbyte-code-and-object-code -fprefer-byte-code A -o exe -v0
+ '$(TEST_HC)' -fbyte-code-and-object-code -fprefer-byte-code A -o exe -v0
./exe
diff --git a/testsuite/tests/driver/Makefile b/testsuite/tests/driver/Makefile
index 156fc0b58c0..c3cc7029d3c 100644
--- a/testsuite/tests/driver/Makefile
+++ b/testsuite/tests/driver/Makefile
@@ -788,7 +788,7 @@ T22044:
.PHONY: T22669
T22669:
- echo ":q" | "$(TEST_HC)" $(TEST_HC_OPTS) -v0 --interactive T22669
+ echo ":q" | "$(TEST_HC)" $(TEST_HC_OPTS_INTERACTIVE) T22669
! test -f T22669.o-boot
diff --git a/testsuite/tests/driver/boot-target/Makefile b/testsuite/tests/driver/boot-target/Makefile
index d9404ccc8c1..b153e4a135e 100644
--- a/testsuite/tests/driver/boot-target/Makefile
+++ b/testsuite/tests/driver/boot-target/Makefile
@@ -1,8 +1,8 @@
boot1:
- $(TEST_HC) -c A.hs-boot B.hs
+ '$(TEST_HC)' -c A.hs-boot B.hs
boot2:
- $(TEST_HC) A.hs-boot A.hs B.hs -v0
+ '$(TEST_HC)' A.hs-boot A.hs B.hs -v0
boot3:
- $(TEST_HC) A.hs-boot B.hs -v0
\ No newline at end of file
+ '$(TEST_HC)' A.hs-boot B.hs -v0
diff --git a/testsuite/tests/driver/fat-iface/Makefile b/testsuite/tests/driver/fat-iface/Makefile
index e74578a4913..18ef6c60fee 100644
--- a/testsuite/tests/driver/fat-iface/Makefile
+++ b/testsuite/tests/driver/fat-iface/Makefile
@@ -55,5 +55,5 @@ T22807: clean
T22807_ghci: clean
"$(TEST_HC)" $(TEST_HC_OPTS) T22807_ghci.hs -fno-full-laziness -fhide-source-paths -fwrite-if-simplified-core -O2 -dynamic -v0
- "$(TEST_HC)" $(TEST_HC_OPTS) -v0 --interactive -fhide-source-paths -fno-full-laziness < T22807_ghci.script
+ "$(TEST_HC)" $(TEST_HC_OPTS_INTERACTIVE) -fhide-source-paths -fno-full-laziness < T22807_ghci.script
diff --git a/testsuite/tests/linters/regex-linters/check-cpp.py b/testsuite/tests/linters/regex-linters/check-cpp.py
index 4cc22579841..fa215e17974 100644
--- a/testsuite/tests/linters/regex-linters/check-cpp.py
+++ b/testsuite/tests/linters/regex-linters/check-cpp.py
@@ -13,12 +13,12 @@ linters = [
message='CPP macros should not have a space between the macro name and their argument list'),
RegexpLinter(r'ASSERT2\s+\(',
message='CPP macros should not have a space between the macro name and their argument list'),
- RegexpLinter(r'#ifdef\s+',
- message='`#if defined(x)` is preferred to `#ifdef x`'),
+ # RegexpLinter(r'#ifdef\s+',
+ # message='`#if defined(x)` is preferred to `#ifdef x`'),
RegexpLinter(r'#if\s+defined\s+',
message='`#if defined(x)` is preferred to `#if defined x`'),
- RegexpLinter(r'#ifndef\s+',
- message='`#if !defined(x)` is preferred to `#ifndef x`'),
+ # RegexpLinter(r'#ifndef\s+',
+ # message='`#if !defined(x)` is preferred to `#ifndef x`'),
]
for l in linters:
diff --git a/testsuite/tests/perf/compiler/Makefile b/testsuite/tests/perf/compiler/Makefile
index e7775ebd9e5..bfa4b2addfa 100644
--- a/testsuite/tests/perf/compiler/Makefile
+++ b/testsuite/tests/perf/compiler/Makefile
@@ -21,7 +21,7 @@ MultiModulesRecomp:
# containing core expressions, aka `mi_extra_decls` are populated.
MultiModulesRecompDefsWithCore:
./genMultiLayerModulesCore
- '$(TEST_HC)' --interactive $(TEST_HC_OPTS) -e "" -fwrite-if-simplified-core MultiLayerModules
+ '$(TEST_HC)' $(TEST_HC_OPTS_INTERACTIVE) -e "" -fwrite-if-simplified-core MultiLayerModules
MultiModulesDefsWithCore:
./genMultiLayerModulesCore
--
GitLab